@@ -51,18 +51,6 @@ def test_review_redirect_is_least_privilege_and_does_not_execute_review() -> Non
5151 )
5252
5353
54- def test_formal_review_rubric_is_inert_and_uses_formal_submission () -> None :
55- rubric = (ROOT / "skills/pr-review/SKILL.md" ).read_text ()
56- metadata = yaml .safe_load (rubric .split ("---" , 2 )[1 ])
57- assert metadata ["name" ] == "pr-review"
58- assert metadata ["disable-model-invocation" ] is True
59- assert metadata ["user_invocable" ] is False
60- assert "mode=light" in rubric
61- assert "mode=strict" in rubric
62- assert "Do not run GitHub commands or" in rubric
63- assert "Never approve an incomplete" in rubric
64-
65-
6654def test_review_redirect_workflow_has_no_other_execution_or_permissions () -> None :
6755 workflow = yaml .safe_load ((ROOT / ".github/workflows/claude-review.yml" ).read_text ())
6856 assert workflow ["permissions" ] == {}
@@ -71,23 +59,6 @@ def test_review_redirect_workflow_has_no_other_execution_or_permissions() -> Non
7159 assert events == {"issue_comment" : {"types" : ["created" ]}}
7260
7361
74- def test_review_policy_preserves_the_retired_light_review_rules () -> None :
75- rubric = (ROOT / "skills/pr-review/SKILL.md" ).read_text ()
76- for rule in (
77- "Critical bugs or logic errors" ,
78- "Typos in code, comments, or strings" ,
79- "Missing or insufficient test coverage for changed code" ,
80- "Outdated or inaccurate documentation affected by the changes" ,
81- "Style preferences or formatting" ,
82- "Minor naming suggestions" ,
83- "Architectural opinions or refactoring ideas" ,
84- "Performance unless there is a clear, measurable issue" ,
85- ):
86- assert rule in rubric
87- assert "post comments directly" in rubric
88- assert 'post "LGTM"' not in rubric
89-
90-
9162@pytest .mark .parametrize (
9263 "notice" , ["Use /review" , "Use /review mode=strict" , "$(touch injected) `touch injected` ' \" ;\n /review" ]
9364)
0 commit comments