feat(audio-segmentation): in-memory segment handoff + agent-ready contracts - #2338
Open
shubhamNvidia wants to merge 1 commit into
Open
feat(audio-segmentation): in-memory segment handoff + agent-ready contracts#2338shubhamNvidia wants to merge 1 commit into
shubhamNvidia wants to merge 1 commit into
Conversation
Adds describe() contracts to the speaker-separation and VAD segmentation stages so a planner can tell what each reads and writes, and how it changes row counts, before running it. Depends on the agent-ready foundation (nemo_curator/stages/audio/_agent/), which must merge first. Signed-off-by: Shubham Bhawsar <shbhawsar@nvidia.com>
Contributor
Greptile SummaryAdds configurable in-memory and file-backed audio handoff to speaker separation and VAD segmentation, together with agent-facing stage contracts and configurable payload keys.
Confidence Score: 5/5The PR appears safe to merge after its explicitly documented agent-ready foundation dependency is present. No unacknowledged concrete defect with an established reachable failure remains in the reviewed changes. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[AudioTask] --> B{Input residency}
B -->|Waveform| C[In-memory audio]
B -->|File| D[Load source file]
C --> E{Segmentation stage}
D --> E
E -->|VAD fan-out| F[Per-segment AudioTasks]
E -->|VAD nested| G[Task with nested segments]
E -->|Speaker separation| H[Per-speaker AudioTasks]
H --> I{Output residency}
I -->|Keep waveform| J[In-memory speaker waveform]
I -->|Write to disk| K[Stable per-speaker WAV path]
Reviews (1): Last reviewed commit: "feat(audio-segmentation): make segmentat..." | Re-trigger Greptile |
shubhamNvidia
requested review from
ayushdg,
mohammadaaftabv and
sarahyurick
and removed request for
meatybobby
August 25, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contracts:
describe()+*_keyparams on speaker-separation and VAD segmentation, with honest cardinality (these produce a nested per-segment list / fan out).New functionality
keep_waveform_in_task,keep_segment_waveform_in_task) — hand the cut waveforms straight to the next stage instead of writing every segment to disk and re-reading it. On a diarize→ASR chain this removes a full write+read of the corpus.write_to_disk,separated_audio_dir) — writing separated audio is now opt-in and its destination is configurable, rather than implied.Depends on the agent-ready foundation, #2332 — that must merge first (this branch imports
nemo_curator/stages/audio/_agent/, so CI here stays red until it lands).