feat(audio-advanced-pipelines): make AudioDataFilterStage agent-ready - #2342
Open
shubhamNvidia wants to merge 1 commit into
Open
feat(audio-advanced-pipelines): make AudioDataFilterStage agent-ready#2342shubhamNvidia wants to merge 1 commit into
shubhamNvidia wants to merge 1 commit into
Conversation
Adds a describe() contract to the composite audio data-filter pipeline so a planner can tell what it reads and writes before running it. Depends on the agent-ready foundation (nemo_curator/stages/audio/_agent/), which must merge first. Signed-off-by: Shubham Bhawsar <shbhawsar@nvidia.com>
Contributor
Greptile SummaryAdds the agent-ready interface and typed
Confidence Score: 5/5No unacknowledged blocking or independently actionable issue was identified in this change. The only concrete current failure is the missing agent-ready dependency, which the PR explicitly documents as expected until prerequisite #2332 lands; no supported topology was shown to violate the new per-row-independence declaration. Important Files Changed
Reviews (1): Last reviewed commit: "feat(audio-advanced-pipelines): make Aud..." | Re-trigger Greptile |
shubhamNvidia
requested review from
ayushdg,
mohammadaaftabv and
sarahyurick
and removed request for
suiyoubi
August 25, 2026 12:01
shubhamNvidia
added a commit
to shubhamNvidia/Curator
that referenced
this pull request
Aug 25, 2026
The complete audio agent work as one branch: the same stage-side contracts split across PRs NVIDIA-NeMo#2332-NVIDIA-NeMo#2342, plus the agent that consumes them. Stages (nemo_curator/stages/audio/): - the _agent/ contract layer (AgentReady, StageContract, roles, input residency, discovery, planning, conformance) and the public agent.py entry point - describe() contracts and *_key params across common, preprocessing, io, filtering, metrics, segmentation, tagging, inference, alm, datasets and advanced_pipelines - new stages: ChannelCount, SampleRateFilter, CreateInitialManifestAudioFolder, PreserveByValueConditions, ManifestCheckpoint, ManifestGroupExport, DocumentBatchJsonlWriter Agent (nemo_curator/audio_agent/): - deterministic verbs (discover/describe/validate/smoke/run/report/reuse/delta), knowledge cards, recipes, and the host skills Supporting: resource telemetry used by smoke calibration (utils/performance_utils.py, opt-in via RESOURCE_PROBE in backends/base.py), the nemo-curator-audio console script, and the audio_agent CI matrix entry. Verified: 51/51 stages pass static conformance, the stage-compatibility baseline hash is unchanged, and whole-repo `ruff check` is clean. Signed-off-by: Shubham Bhawsar <shbhawsar@nvidia.com>
shubhamNvidia
added a commit
to shubhamNvidia/Curator
that referenced
this pull request
Aug 25, 2026
The complete audio agent work as one branch: the same stage-side contracts split across PRs NVIDIA-NeMo#2332-NVIDIA-NeMo#2342, plus the agent that consumes them. Stages (nemo_curator/stages/audio/): - the _agent/ contract layer (AgentReady, StageContract, roles, input residency, discovery, planning, conformance) and the public agent.py entry point - describe() contracts and *_key params across common, preprocessing, io, filtering, metrics, segmentation, tagging, inference, alm, datasets and advanced_pipelines - new stages: ChannelCount, SampleRateFilter, CreateInitialManifestAudioFolder, PreserveByValueConditions, ManifestCheckpoint, ManifestGroupExport, DocumentBatchJsonlWriter Agent (nemo_curator/audio_agent/): - deterministic verbs (discover/describe/validate/smoke/run/report/reuse/delta), knowledge cards, recipes, and the host skills Supporting: resource telemetry used by smoke calibration (utils/performance_utils.py, opt-in via RESOURCE_PROBE in backends/base.py), the nemo-curator-audio console script, and the audio_agent CI matrix entry. Verified: 51/51 stages pass static conformance, the stage-compatibility baseline hash is unchanged, and whole-repo `ruff check` is clean. Signed-off-by: Shubham Bhawsar <shbhawsar@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contracts only — no behavior change. Adds a
describe()contract to the compositeAudioDataFilterStageso the planner can see what the whole bundled pipeline reads and writes, and that it writes to disk.It composes filtering / postprocessing / preprocessing / segmentation, so it is best merged after those.
Depends on the agent-ready foundation, #2332 — that must merge first (this branch imports
nemo_curator/stages/audio/_agent/, so CI here stays red until it lands).