Skip to content

feat(audio-advanced-pipelines): make AudioDataFilterStage agent-ready - #2342

Open
shubhamNvidia wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
shubhamNvidia:agent/advanced_pipelines
Open

feat(audio-advanced-pipelines): make AudioDataFilterStage agent-ready#2342
shubhamNvidia wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
shubhamNvidia:agent/advanced_pipelines

Conversation

@shubhamNvidia

Copy link
Copy Markdown
Contributor

Contracts only — no behavior change. Adds a describe() contract to the composite AudioDataFilterStage so the planner can see what the whole bundled pipeline reads and writes, and that it writes to disk.

It composes filtering / postprocessing / preprocessing / segmentation, so it is best merged after those.

Depends on the agent-ready foundation, #2332 — that must merge first (this branch imports nemo_curator/stages/audio/_agent/, so CI here stays red until it lands).

Adds a describe() contract to the composite audio data-filter pipeline so a planner can tell what it reads and writes before running it.

Depends on the agent-ready foundation (nemo_curator/stages/audio/_agent/), which must merge first.

Signed-off-by: Shubham Bhawsar <shbhawsar@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shubhamNvidia
shubhamNvidia marked this pull request as ready for review August 25, 2026 11:19
@shubhamNvidia
shubhamNvidia requested a review from a team as a code owner August 25, 2026 11:19
@shubhamNvidia
shubhamNvidia requested review from suiyoubi and removed request for a team August 25, 2026 11:19
@greptile-apps

greptile-apps Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds the agent-ready interface and typed AudioTask boundary to AudioDataFilterStage.

  • Introduces a describe() contract that marks the composite as non-wrappable.
  • Declares every supported topology independent per input row.
  • Depends on the separately proposed agent-ready foundation.

Confidence Score: 5/5

No unacknowledged blocking or independently actionable issue was identified in this change.

The only concrete current failure is the missing agent-ready dependency, which the PR explicitly documents as expected until prerequisite #2332 lands; no supported topology was shown to violate the new per-row-independence declaration.

Important Files Changed

Filename Overview
nemo_curator/stages/audio/advanced_pipelines/audio_data_filter/audio_data_filter.py Adds agent-ready inheritance and a planner-facing contract; no unacknowledged actionable defect was established.

Reviews (1): Last reviewed commit: "feat(audio-advanced-pipelines): make Aud..." | Re-trigger Greptile

@shubhamNvidia
shubhamNvidia requested review from ayushdg, mohammadaaftabv and sarahyurick and removed request for suiyoubi August 25, 2026 12:01
shubhamNvidia added a commit to shubhamNvidia/Curator that referenced this pull request Aug 25, 2026
The complete audio agent work as one branch: the same stage-side contracts split
across PRs NVIDIA-NeMo#2332-NVIDIA-NeMo#2342, plus the agent that consumes them.

Stages (nemo_curator/stages/audio/):
  - the _agent/ contract layer (AgentReady, StageContract, roles, input residency,
    discovery, planning, conformance) and the public agent.py entry point
  - describe() contracts and *_key params across common, preprocessing, io,
    filtering, metrics, segmentation, tagging, inference, alm, datasets and
    advanced_pipelines
  - new stages: ChannelCount, SampleRateFilter, CreateInitialManifestAudioFolder,
    PreserveByValueConditions, ManifestCheckpoint, ManifestGroupExport,
    DocumentBatchJsonlWriter

Agent (nemo_curator/audio_agent/):
  - deterministic verbs (discover/describe/validate/smoke/run/report/reuse/delta),
    knowledge cards, recipes, and the host skills

Supporting: resource telemetry used by smoke calibration
(utils/performance_utils.py, opt-in via RESOURCE_PROBE in backends/base.py), the
nemo-curator-audio console script, and the audio_agent CI matrix entry.

Verified: 51/51 stages pass static conformance, the stage-compatibility baseline
hash is unchanged, and whole-repo `ruff check` is clean.

Signed-off-by: Shubham Bhawsar <shbhawsar@nvidia.com>
shubhamNvidia added a commit to shubhamNvidia/Curator that referenced this pull request Aug 25, 2026
The complete audio agent work as one branch: the same stage-side contracts split
across PRs NVIDIA-NeMo#2332-NVIDIA-NeMo#2342, plus the agent that consumes them.

Stages (nemo_curator/stages/audio/):
  - the _agent/ contract layer (AgentReady, StageContract, roles, input residency,
    discovery, planning, conformance) and the public agent.py entry point
  - describe() contracts and *_key params across common, preprocessing, io,
    filtering, metrics, segmentation, tagging, inference, alm, datasets and
    advanced_pipelines
  - new stages: ChannelCount, SampleRateFilter, CreateInitialManifestAudioFolder,
    PreserveByValueConditions, ManifestCheckpoint, ManifestGroupExport,
    DocumentBatchJsonlWriter

Agent (nemo_curator/audio_agent/):
  - deterministic verbs (discover/describe/validate/smoke/run/report/reuse/delta),
    knowledge cards, recipes, and the host skills

Supporting: resource telemetry used by smoke calibration
(utils/performance_utils.py, opt-in via RESOURCE_PROBE in backends/base.py), the
nemo-curator-audio console script, and the audio_agent CI matrix entry.

Verified: 51/51 stages pass static conformance, the stage-compatibility baseline
hash is unchanged, and whole-repo `ruff check` is clean.

Signed-off-by: Shubham Bhawsar <shbhawsar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant