Skip to content

Commit ad783b5

Browse files
authored
Change initial eigen values in KLShampoo to 1 (#310)
* change init value Signed-off-by: Hao Wu <skyw@nvidia.com> * grammar fix Signed-off-by: Hao Wu <skyw@nvidia.com> --------- Signed-off-by: Hao Wu <skyw@nvidia.com>
1 parent 4bbed19 commit ad783b5

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎emerging_optimizers/shampoo/shampoo.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,10 @@ def init_state(
195195
{
196196
"Q_L": torch.eye(m, device=device),
197197
"Q_R": torch.eye(n, device=device),
198-
"eigvals_L": torch.zeros(m, device=device),
199-
"eigvals_R": torch.zeros(n, device=device),
198+
# Initialize eigenvalues to one to skip KL correction for the first step.
199+
# They will be overwritten immediately afterward.
200+
"eigvals_L": torch.ones(m, device=device),
201+
"eigvals_R": torch.ones(n, device=device),
200202
}
201203
)
202204
return state

0 commit comments

Comments
 (0)