Repository navigation
Fallback to single GPU if tp_group has size 1 - #314
Merged
Merged
Conversation
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
 [Low impact] The PR appears safe to merge; the previous finding is fixed and no new issues were found. Summary
Reviews (3) · Last reviewed commit: "revert" · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+337
to
340
| tp_size = get_pg_size(tp_group) | ||
| if partition_dim is None or tp_size == 1: | ||
| # Fallback path for non TP params. | ||
| return newton_schulz(x, steps, coefficient_type, use_syrk=use_syrk) |
Contributor
There was a problem hiding this comment.
Both error tests in tests/test_muon_utils.py:464-478 pass tp_group=None, so get_pg_size returns 1 and this branch returns normally instead of raising the expected ValueError. Update those tests to match the intended behavior, or keep the checks they expect.
yashaswikarnati
approved these changes
Oct 20, 2026
Contributor
Author
|
/ok to test dcc9903 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where size 1 group is passed into newton_schulze_tp. Technically caller should never do that, but it is also trivial to guard here.