Repository navigation
fix: vllm e2e job uses matrix context without strategy block - #750
Closed
andrewwhitecdw wants to merge 1 commit into
Closed
andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
chtruong814
approved these changes
Aug 23, 2026
Contributor
|
/ok to test 57c3538 |
Contributor
|
@andrewwhitecdw Thanks for the PR for cleaning this up. Could you actually combine your changes from these other PRs? It'll be faster for us to review together since it's CI related. |
chtruong814
requested changes
Aug 23, 2026
chtruong814
left a comment
chtruong814
left a comment
Contributor
There was a problem hiding this comment.
Please see the comment about aggregating the other CI proposed changes into this PR.
Contributor
Author
|
Consolidating these related CI fixes into a single PR: #755. Thanks for the suggestion! |
andrewwhitecdw
added a commit
to andrewwhitecdw/Export-Deploy
that referenced
this pull request
Aug 31, 2026
This combines three related CI fixes so they can be reviewed together:
- `.github/actions/test-template/action.yml`: corrects the `is_optional`
description so it matches the actual behavior.
- `.github/workflows/cicd-main.yml`: adds missing `strategy`/`matrix` blocks to
the trt-onnx, vllm, and inframework e2e jobs, and uses `${{ matrix.script }}`
and `${{ matrix.is_optional }}` instead of hard-coded values.
Tests
- `unit_tests/github_actions/test_optional_description.py`: verifies the
`is_optional` description no longer inverts the behavior.
- `tests/test_cicd_yaml.py`: verifies the e2e jobs define a strategy block
before referencing matrix context.
Closes NVIDIA-NeMo#728, NVIDIA-NeMo#749, NVIDIA-NeMo#750.
Signed-off-by: Andrew White <andrewwhitecdw@users.noreply.github.com>
andrewwhitecdw
added a commit
to andrewwhitecdw/Export-Deploy
that referenced
this pull request
Aug 31, 2026
This combines three related CI fixes so they can be reviewed together:
- `.github/actions/test-template/action.yml`: corrects the `is_optional`
description so it matches the actual behavior.
- `.github/workflows/cicd-main.yml`: adds missing `strategy`/`matrix` blocks to
the trt-onnx, vllm, and inframework e2e jobs, and uses `${{ matrix.script }}`
and `${{ matrix.is_optional }}` instead of hard-coded values.
Tests
- `unit_tests/github_actions/test_optional_description.py`: verifies the
`is_optional` description no longer inverts the behavior.
- `tests/test_cicd_yaml.py`: verifies the e2e jobs define a strategy block
before referencing matrix context.
Closes NVIDIA-NeMo#728, NVIDIA-NeMo#749, NVIDIA-NeMo#750.
Signed-off-by: Andrew White <andrewwhitecdw@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue in
.github/workflows/cicd-main.yml: vllm e2e job uses matrix context without strategy block.Changes
.github/workflows/cicd-main.yml: vllm e2e job uses matrix context without strategy block.Details
Tests
Contributor guidelines
Per this repo's CONTRIBUTING.md:
Signed-off-bytrailer, DCO).