Repository navigation
fix: combine CI matrix strategy and action description fixes - #755
Closed
andrewwhitecdw wants to merge 1 commit into
Closed
andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
This was referenced Aug 24, 2026
This combines three related CI fixes so they can be reviewed together:
- `.github/actions/test-template/action.yml`: corrects the `is_optional`
description so it matches the actual behavior.
- `.github/workflows/cicd-main.yml`: adds missing `strategy`/`matrix` blocks to
the trt-onnx, vllm, and inframework e2e jobs, and uses `${{ matrix.script }}`
and `${{ matrix.is_optional }}` instead of hard-coded values.
Tests
- `unit_tests/github_actions/test_optional_description.py`: verifies the
`is_optional` description no longer inverts the behavior.
- `tests/test_cicd_yaml.py`: verifies the e2e jobs define a strategy block
before referencing matrix context.
Closes NVIDIA-NeMo#728, NVIDIA-NeMo#749, NVIDIA-NeMo#750.
Signed-off-by: Andrew White <andrewwhitecdw@users.noreply.github.com>
andrewwhitecdw
force-pushed
the
bugfix/combine-ci-matrix-and-action-description
branch
from
August 31, 2026 16:31
a98d3f4 to
c77aae1
Compare
andrewwhitecdw
requested review from
athitten,
meatybobby,
oyilmaz-nvidia and
pthombre
as code owners
August 31, 2026 16:31
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines the changes from #728, #749, and #750 so the related CI fixes can be reviewed together.
Changes
.github/actions/test-template/action.yml: corrects theis_optionaldescription so it matches the actual behavior (fix: is_optional input description inverts actual behavior #728)..github/workflows/cicd-main.yml: adds missingstrategy/matrixblocks to the trt-onnx, vllm, and inframework e2e jobs, and uses${{ matrix.script }}and${{ matrix.is_optional }}instead of hard-coded values (fix: inframework e2e job uses matrix context without strategy block #749, fix: vllm e2e job uses matrix context without strategy block #750).unit_tests/github_actions/test_optional_description.pyandtests/test_cicd_yaml.py.Tests
python unit_tests/github_actions/test_optional_description.pypython tests/test_cicd_yaml.pyCloses #728, closes #749, closes #750.