Repository navigation
chore: Update CI image to use pytorch 26.08 and vllm 0.29.0 - #764
Merged
Merged
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
EngineArgs.__init__() no longer accepts swap_space in vLLM 0.29.0 - vLLM V1 dropped host-memory swap-on-preemption in favor of KV cache recomputation, and swap_space had no remaining consumer after best_of sampling was removed. This was breaking HFRayDeployable startup with TypeError: EngineArgs.__init__() got an unexpected keyword argument 'swap_space'. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814
requested review from
athitten,
oyilmaz-nvidia and
pthombre
as code owners
September 9, 2026 21:18
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
balasaajay
approved these changes
Sep 10, 2026
oyilmaz-nvidia
approved these changes
Sep 10, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: Update CI image to use pytorch 26.08 and vllm 0.29.0
Also bump to newer MBridge commit on main branch.