Skip to content

ci(review): AUT-2439 migrate legacy Claude commands to /review - #767

Merged
ko3n1g merged 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:ci/migrate-legacy-review
Oct 2, 2026
Merged

ko3n1g merged 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:ci/migrate-legacy-review

Conversation

@svcnemo-autobot

Copy link
Copy Markdown
Contributor

Background

Extend NVIDIA/Megatron-LM#7675 to Export-Deploy while preserving its review policy.

What changed

  • Replace legacy Claude inference with least-privilege notices for exact legacy commands from trusted, non-bot PR commenters.
  • Preserve all focus/exclusion rules in an inert formal /review rubric.
  • Document commands and activation prerequisites; add eight policy and literal-shell-argument tests.

Details

flowchart LR
  Legacy[Trusted legacy command] --> Notice[Notice only]
  User[User posts /review] --> Profile[Review profile]
  Profile --> Rubric[Protected main rubric]
Loading

No checkout or inference credentials remain. Raw exact matching excludes trailing whitespace; tests assert the complete GitHub condition, not an evaluator behavior matrix. Profile registration and a verified Ready snapshot are deployment prerequisites, not established here.

Tested

Signed-head merge checkout against ff09e7db, reused CI image, Python 3.12.3:

  • Native L0 CPU script exited 0: 566 passed, 185 skipped, one deselected; coverage XML/report succeeded (64%). All eight new cases passed.
  • Whole-tree Ruff 0.9.10, changed-file pre-commit (Ruff 0.9.9), pinned CI copyright and detect-secrets 1.5.0 payloads passed.
  • Full pre-commit fails identically on the base: two existing EOF violations and an underscore Markdown filename. Hook edits were restored.

Local non-root gVisor used a searchable PATH and local cache instead of CI TestData/64Gi shared memory. Ray callback assertions and a Torch shutdown UnicodeDecodeError remain despite exit 0; no clean-runtime claim. GPU/functional tests, CI Python 3.10 lint, and GitHub CI remain unverified. No product/dependency changes were made for validation.

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested a review from a team as a code owner October 1, 2026 23:11
@copy-pr-bot

copy-pr-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test 0b9e8d7

@ko3n1g
ko3n1g merged commit 4d5c837 into NVIDIA-NeMo:main Oct 2, 2026
24 checks passed

This branch was successfully deployed

2 active deployments
nemo-ci — 0b9e8d79 Deployed Oct 12, 2026 by copy-pr-bot[bot] via cicd-e2e-tests-trt-onnx #3089
test — 0b9e8d79 Deployed Oct 1, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #3089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants