Skip to content

Commit 9784fbc

Browse files
committed
Allow aws ofi reinstall to be optional
Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
1 parent 8f43506 commit 9784fbc

1 file changed

Lines changed: 22 additions & 3 deletions

File tree

‎docker/Dockerfile.fw_base‎

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@
1414

1515
# Build layer variables
1616
# To install trtllm set FW_DEP_BUILDER=trtllm_builder, FW_BASE_FINAL=trtllm_install
17-
# To exclude trtllm set FW_DEP_BUILDER=base, FW_BASE_FINAL=fw_dep_builder
17+
# To exclude trtllm set FW_DEP_BUILDER=base, FW_BASE_FINAL=fw_toolkit_builder
18+
# To skip AWS-OFI-NCCL set FW_NETWORK_LAYER=fw_dep_builder
1819
ARG FW_DEP_BUILDER
1920
ARG FW_BASE_FINAL
21+
ARG FW_NETWORK_LAYER=aws_ofi_builder
2022

2123
ARG NEMO_FW_BASE_IMAGE
2224
FROM ${NEMO_FW_BASE_IMAGE} AS base
@@ -177,14 +179,20 @@ RUN curl -LsSf https://astral.sh/uv/${UV_VERSION}/install.sh | XDG_BIN_HOME=/usr
177179

178180
##############################################################################
179181
##
182+
## AWS-OFI-NCCL upgrade stage
183+
##
180184
## Upgrade AWS-OFI-NCCL from v1.17.0 to v1.17.3
181185
##
182186
## IMPORTANT: Do NOT remove ibverbs/libmlx5 packages — they are required for
183187
## InfiniBand/RDMA transport on Slurm clusters with Mellanox ConnectX adapters.
184188
## The EFA stack is installed alongside (not replacing) the existing IB stack.
185189
##
190+
## To skip this stage, set FW_NETWORK_LAYER=fw_dep_builder
191+
##
186192
##############################################################################
187193

194+
FROM fw_dep_builder AS aws_ofi_builder
195+
188196
RUN apt-get update -y
189197

190198
#################################################
@@ -253,6 +261,17 @@ RUN export LD_LIBRARY_PATH=/opt/amazon/efa/lib:/opt/amazon/openmpi/lib:${LD_LIBR
253261
&& rm -rf aws-ofi-nccl-${AWS_OFI_NCCL_VERSION//v} \
254262
&& rm aws-ofi-nccl-${AWS_OFI_NCCL_VERSION//v}.tar.gz
255263

264+
##############################################################################
265+
##
266+
## CUDA toolkit + DeepEP stage
267+
##
268+
## Chains from FW_NETWORK_LAYER (default: aws_ofi_builder).
269+
## Set FW_NETWORK_LAYER=fw_dep_builder to skip the AWS-OFI-NCCL stage.
270+
##
271+
##############################################################################
272+
273+
FROM ${FW_NETWORK_LAYER} AS fw_toolkit_builder
274+
256275
##############################################################################
257276
##
258277
## Reinstall CUDA toolkit packages
@@ -327,7 +346,7 @@ RUN --mount=type=bind,source=docker/patches/deepep.patch,target=/opt/deepep.patc
327346
##
328347
##############################################################################
329348

330-
FROM fw_dep_builder AS trtllm_install
349+
FROM fw_toolkit_builder AS trtllm_install
331350

332351
WORKDIR /opt/tensorrt_llm
333352

@@ -353,7 +372,7 @@ RUN --mount=type=bind,from=trtllm_wheel,source=/src/tensorrt_llm/build/,target=/
353372
## Final layer of FW_BASE container
354373
##
355374
## When TRTLLM is re-installed, FW_BASE_FINAL=trtllm_install
356-
## default, FW_BASE_FINAL=fw_dep_builder
375+
## default, FW_BASE_FINAL=fw_toolkit_builder
357376
##
358377
##############################################################################
359378

0 commit comments

Comments
 (0)