Skip to content

Commit c908ebe

Browse files
committed
address comments
Signed-off-by: Li Ding <liding@nvidia.com>
1 parent 61f9e9f commit c908ebe

4 files changed

Lines changed: 4 additions & 13 deletions

File tree

‎examples/conversion/compare_hf_and_megatron/compare.py‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -715,9 +715,6 @@ def compare_models_one_step(args) -> None:
715715
tokenizer, processor, args.image_path, args.prompt, is_vl_model, args.tp
716716
)
717717

718-
print(f"{input_ids.shape=}")
719-
print(f"{input_ids=}")
720-
721718
# Move to GPU
722719
input_ids = input_ids.cuda()
723720
if pixel_values is not None:

‎examples/models/nemotron_3/super/finetune_nemotron_3_super.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,7 @@ def main() -> None:
6464
"""
6565
args, cli_overrides = parse_cli_args()
6666

67-
cfg: ConfigContainer = finetune_config(
68-
seq_length=args.seq_length, peft=args.peft, packed_sequence=args.packed_sequence
69-
)
67+
cfg: ConfigContainer = finetune_config(peft=args.peft)
7068
cfg.model.seq_length = args.seq_length
7169

7270
# Convert the initial Python dataclass to an OmegaConf DictConfig for merging

‎examples/models/nemotron_3/super/pretrain_nemotron_3_super.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def parse_cli_args() -> Tuple[argparse.Namespace, list[str]]:
5858

5959
def main() -> None:
6060
"""
61-
Entry point for the Mamba 8B pretraining script.
61+
Entry point for the Nemotron 3 Super pretraining script.
6262
"""
6363
args, cli_overrides = parse_cli_args()
6464

‎examples/models/nemotron_3/super/qat_nemotron_3_super.py‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,9 @@ def main() -> None:
7777
print(f"[yellow]torchrun examples/models/quantize.py --megatron-save-path {args.megatron_load_path}[/yellow]")
7878
sys.exit(1)
7979

80-
cfg: ConfigContainer = finetune_config(
81-
pretrained_checkpoint=args.megatron_load_path,
82-
seq_length=args.seq_length,
83-
peft=None,
84-
packed_sequence=args.packed_sequence,
85-
)
80+
cfg: ConfigContainer = finetune_config(peft=None)
8681
cfg.model.seq_length = args.seq_length
82+
cfg.checkpoint.pretrained_checkpoint = args.megatron_load_path
8783

8884
# Check for ModelOpt state
8985
checkpoint_to_check = cfg.checkpoint.pretrained_checkpoint or cfg.checkpoint.load

0 commit comments

Comments
 (0)