Skip to content

Commit d74585b

Browse files
committed
fix(deps): keep MCore dev pin separate
Signed-off-by: Chen Cui <chcui@nvidia.com>
1 parent dff6445 commit d74585b

4 files changed

Lines changed: 117 additions & 86 deletions

File tree

‎.github/scripts/test_docker_dependency_layers.sh‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,14 +242,14 @@ if "$temporary_dir/revision-validator" "$revision_repo" not-a-full-sha; then
242242
exit 1
243243
fi
244244

245-
if ! grep -A1 '^te = \[$' pyproject.toml | grep -Fxq ' "transformer-engine[pytorch,core_cu13]",'; then
246-
echo "Bridge's TE extra must install TransformerEngine's PyTorch and CUDA 13 packages" >&2
245+
if ! grep -A1 '^te = \[$' pyproject.toml | grep -Fxq ' "megatron-core[te]",'; then
246+
echo "Bridge's TE extra must enable the selected MCore ref's TE extra" >&2
247247
exit 1
248248
fi
249249
if ! grep -Fq \
250-
'{ name = "transformer-engine", extras = ["core-cu13", "pytorch"], marker = "extra == '\''te'\''" }' \
250+
'{ name = "megatron-core", extras = ["te"], marker = "extra == '\''te'\''", editable = "3rdparty/Megatron-LM" }' \
251251
uv.lock; then
252-
echo "Bridge's lock metadata must preserve the direct TransformerEngine extras" >&2
252+
echo "Bridge's lock metadata must preserve the MCore TE extra" >&2
253253
exit 1
254254
fi
255255
if grep -q 'transformer-engine @ git+https://github.com/NVIDIA/TransformerEngine.git@' pyproject.toml; then

‎3rdparty/Megatron-LM‎

Submodule Megatron-LM updated 1830 files

‎pyproject.toml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,8 @@ requires-dist = []
161161
# Lane-specific metadata for VCS packages that otherwise compile CUDA extensions during lock.
162162
[[tool.uv.dependency-metadata]]
163163
name = "transformer-engine"
164-
version = "2.14.0+f031cf87"
165-
requires-dist = ["einops", "importlib-metadata", "nvdlfw-inspect", "onnx", "onnxscript", "packaging", "pydantic", "torch"]
164+
version = "2.17.1+4329ff84"
165+
requires-dist = ["pydantic<2.14", "importlib-metadata>=1.0", "packaging", "torch>=2.1", "einops", "onnxscript", "onnx", "nvdlfw-inspect"]
166166

167167
[[tool.uv.dependency-metadata]]
168168
name = "fast-hadamard-transform"
@@ -185,7 +185,7 @@ tensor-inspect = [
185185
"nvdlfw-inspect==0.2.1",
186186
]
187187
te = [
188-
"transformer-engine[pytorch,core_cu13]",
188+
"megatron-core[te]",
189189
]
190190
ssm = [
191191
"mamba-ssm",

0 commit comments

Comments
 (0)