Skip to content

Commit e2e5787

Browse files
committed
Simplified assertion messages for clarity.
Signed-off-by: Ao Tang <aot@nvidia.com>
1 parent d8ded09 commit e2e5787

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

‎tests/unit_tests/models/gemma_vl/test_gemma3_vl_bridge.py‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -274,12 +274,7 @@ def test_mapping_registry_vision_tower_params(self, gemma3_vl_bridge):
274274
assert len(vision_mappings) == 1, "Should have exactly one ReplicatedMapping for vision_tower"
275275

276276
vt_mapping = vision_mappings[0]
277-
assert str(vt_mapping.megatron_param) == "vision_tower.**", (
278-
"Megatron vision_tower param should use wildcard"
279-
)
280-
# Critical: HF param must include the vision_model.* wrapper present in the
281-
# google/gemma-3-4b-it checkpoint (old format keys from SiglipVisionModel).
282-
# Without this, all ~11,800 vision_tower keys fail to load.
277+
assert str(vt_mapping.megatron_param) == "vision_tower.**", "Megatron vision_tower param should use wildcard"
283278
assert str(vt_mapping.hf_param) == "vision_tower.vision_model.**", (
284279
"HF param must map through vision_model.** to match SiglipVisionModel checkpoint keys"
285280
)

0 commit comments

Comments
 (0)