Skip to content

Commit faf6633

Browse files
committed
refactor(performance): remove legacy perf configs
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
1 parent e1edbd3 commit faf6633

48 files changed

Lines changed: 6224 additions & 9803 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎scripts/performance/README.md‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,14 @@
44

55
- Scripts defined in `scripts/performance` are recipes optimized for performance. These scripts can launch pre-training experiments on Slurm based clusters.
66

7-
## Configuration files
7+
## Performance recipe configs
88

9-
There are configuration files- `workload_base_configs.py` for supported models in `scripts/performance/configs`.
9+
Performance-optimized recipes live in `src/megatron/bridge/perf_recipes`. The performance
10+
launcher resolves recipes from that package by model, task, GPU count, GPU type, precision,
11+
and config variant.
1012

11-
- You can override the default configs using these files using command line arguments (recommended) or directly updating these files
13+
- Prefer command-line overrides for one-off changes.
14+
- Add or update flat perf recipe functions in `src/megatron/bridge/perf_recipes` for reusable benchmark configs.
1215

1316
## Setup Instructions
1417

@@ -255,7 +258,7 @@ Mounting cached files is not enough by itself. If `HF_HUB_OFFLINE` remains `0`,
255258

256259
##### Config variant arguments
257260

258-
- `-cv/--config_variant`: Config variant to use (e.g., `"v1"`, `"v2"`). Defaults to `"v2"` (`"v1"` if `"v2"` doens't exist). Use `--list_config_variants` to see available options.
261+
- `-cv/--config_variant`: Config variant to use. Defaults to `"v2"`, which maps to the suffix-less canonical flat perf recipe. Named variants such as `"large_scale"` are supported when a matching flat recipe exists; removed legacy variants such as `"v1"` fail instead of silently selecting another config. Use `--list_config_variants` to see available options.
259262
- `--list_config_variants`: List available config variants for the specified model/task/gpu/dtype and interactively select one (with 15s timeout).
260263

261264
##### Testing arguments

‎scripts/performance/argument_parser.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -905,7 +905,10 @@ def parse_cli_args():
905905
"-cv",
906906
"--config_variant",
907907
type=str,
908-
help="Config variant for workload base configs (used by setup_experiment.py only). Use --list_config_variants to see available options.",
908+
help=(
909+
"Flat perf recipe variant for setup_experiment.py. Defaults to v2, the suffix-less canonical recipe. "
910+
"Named variants such as large_scale are supported when a matching recipe exists."
911+
),
909912
default="v2",
910913
)
911914
config_variant_args.add_argument(

‎scripts/performance/configs/deepseek/__init__.py‎

Lines changed: 0 additions & 146 deletions
This file was deleted.

0 commit comments

Comments
 (0)