Skip to content

feat(data): add text chat collate for unified HF datasets - #4307

Merged
yaoyu-33 merged 56 commits into
mainfrom
kant/pr4169-unified-hf-dataset
Jun 24, 2026
Merged

yaoyu-33 merged 56 commits into
mainfrom
kant/pr4169-unified-hf-dataset

Conversation

@yaoyu-33

@yaoyu-33 yaoyu-33 commented Jun 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Stacked on #4169. Follow-up refactor #4315 is stacked on this PR.

  • add a text-only chat collate path under the existing HF conversation/VLM dataset utilities
  • reuse the fix(data): anchor VLM assistant loss masks to chat templates #4169 assistant-mask helpers for text conversations (build_assistant_loss_mask and build_shifted_labels_and_loss_mask)
  • add text_chat / chat maker aliases and tokenizer fallback for plain LLM checkpoints without an AutoProcessor
  • leave existing model-specific VLM collates untouched

Stack

Current order: #4169 -> #4307 -> #4315.

Validation

  • ruff check on changed files
  • python3 -m py_compile on changed files/tests
  • git diff --check
  • standalone pre-commit run --all-files

Full uv run pre-commit run --all-files was blocked on this workstation before hooks by a platform wheel availability issue for nvidia-resiliency-ext==0.6.0.

Follow-up validation requested

GPU cluster validation is in progress to compare SQuAD loss curves against #4169 using the same config and seed.

yaoyu-33 and others added 30 commits June 1, 2026 20:34
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/nvskills-ci

@yaoyu-33

Copy link
Copy Markdown
Contributor Author

/ok to test 6a2eba2

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/nvskills-ci

@yaoyu-33

Copy link
Copy Markdown
Contributor Author

/ok to test b3336e7

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/nvskills-ci

@yaoyu-33

Copy link
Copy Markdown
Contributor Author

/ok to test 3c08231

@yaoyu-33
yaoyu-33 merged commit 814ad79 into main Jun 24, 2026
129 of 133 checks passed
@yaoyu-33
yaoyu-33 deleted the kant/pr4169-unified-hf-dataset branch June 24, 2026 19:31

This branch was previously deployed

2 inactive deployments
public — 3c08231d Deployed Jun 24, 2026 by copy-pr-bot[bot] via release / finalize / notify #1802
test — 3c08231d Deployed Jun 24, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #16762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:data Dataset builders, preprocessing, and samplers feature New capabilities, enhancements, or enablement work needs-more-tests Requires additional L0 and L1 test coverage before merge ready-to-merge PR is approved, current, and only waiting for CI to pass before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants