Skip to content

refactor(recipes): add h100 recipe namespace - #4622

Merged
yaoyu-33 merged 9 commits into
mainfrom
yuya/remove-perf-configs-h100-recipes
Jul 3, 2026
Merged

refactor(recipes): add h100 recipe namespace#4622
yaoyu-33 merged 9 commits into
mainfrom
yuya/remove-perf-configs-h100-recipes

Conversation

@yaoyu-33

@yaoyu-33 yaoyu-33 commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Move library recipe implementations under hardware-specific h100 modules while keeping legacy recipe names as compatibility wrappers.
  • Normalize canonical library PEFT recipe names to use _peft_ instead of _lora_.
  • Flatten Qwen3/Qwen3.5-VL recipe bodies and remove parameterized recipe helper patterns.
  • Update recipe docs, Fern nightly pages, and recipe tests for the new naming.

Split

This PR is now recipes-only. The legacy performance config removal has been split into #4623.

Validation

  • python3 -m compileall -q src/megatron/bridge/recipes tests/unit_tests/recipes tests/functional_tests/test_groups/recipes/test_qwen35_vl_recipes_pretrain.py scripts/translate_mlm_to_bridge.py
  • uvx pre-commit run --all-files

Note: uv run pre-commit run --all-files is blocked on macOS by nvidia-resiliency-ext==0.6.0 Linux-only wheels.

@yaoyu-33
yaoyu-33 requested review from a team, erhoo82 and malay-nagda as code owners July 2, 2026 01:42
@copy-pr-bot

copy-pr-bot Bot commented Jul 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaoyu-33
yaoyu-33 force-pushed the yuya/remove-perf-configs-h100-recipes branch 2 times, most recently from 8e0a84b to 03210f8 Compare July 2, 2026 02:12
@yaoyu-33 yaoyu-33 added area:recipe Training recipes and launch configs breaking-change Public behavior or API compatibility changes feature New capabilities, enhancements, or enablement work full-test-suite needs-review PR is ready for code review and waiting on a reviewer labels Jul 2, 2026
@yaoyu-33
yaoyu-33 force-pushed the yuya/remove-perf-configs-h100-recipes branch 3 times, most recently from 115309e to 0ad0f90 Compare July 2, 2026 05:04
@yaoyu-33 yaoyu-33 changed the title refactor(recipes): add h100 recipes and remove perf configs refactor(recipes): add h100 recipe namespace Jul 2, 2026
@yaoyu-33 yaoyu-33 mentioned this pull request Jul 2, 2026
Merged
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/nvskills-ci

yaoyu-33
yaoyu-33 commented Jul 2, 2026
View reviewed changes
Comment thread docs/fern/versions/nightly/pages/models/nemotron/nemotron-nano-v2-vl.mdx
yaoyu-33
yaoyu-33 commented Jul 2, 2026
View reviewed changes
Comment thread docs/fern/versions/nightly/pages/models/nemotron/nemotron-nano-v2-vl.mdx
yaoyu-33
yaoyu-33 commented Jul 2, 2026
View reviewed changes
Comment thread docs/fern/versions/nightly/pages/models/nemotron/nemotron-nano-v2-vl.mdx
yaoyu-33
yaoyu-33 commented Jul 2, 2026
View reviewed changes
Comment thread docs/fern/versions/nightly/pages/index.mdx Outdated
yaoyu-33
yaoyu-33 commented Jul 2, 2026
View reviewed changes
Comment thread docs/fern/versions/nightly/pages/recipe-usage.mdx Outdated
yaoyu-33
yaoyu-33 commented Jul 2, 2026
View reviewed changes
Comment thread docs/models/nemotron/nemotron-nano-v2-vl.md
yaoyu-33
yaoyu-33 commented Jul 2, 2026
View reviewed changes
Comment thread docs/recipe-usage.md Outdated
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/nvskills-ci

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/nvskills-ci

yaoyu-33
yaoyu-33 commented Jul 2, 2026
View reviewed changes
Comment thread examples/models/nemotron/nemotron_vl/finetune_nemotron_nano_v2_vl.py
yaoyu-33
yaoyu-33 commented Jul 2, 2026
View reviewed changes
Comment thread examples/models/nemotron/nemotron_vl/finetune_nemotron_nano_v2_vl.py Outdated
yaoyu-33
yaoyu-33 commented Jul 2, 2026
View reviewed changes
Comment thread examples/models/qwen/qwen_vl/finetune_qwen_vl.py Outdated
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/nvskills-ci

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/nvskills-ci

@yaoyu-33
yaoyu-33 force-pushed the yuya/remove-perf-configs-h100-recipes branch from 254cf13 to bddf459 Compare July 2, 2026 21:20
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/nvskills-ci

@yaoyu-33
yaoyu-33 force-pushed the yuya/remove-perf-configs-h100-recipes branch from bddf459 to 1b83cd7 Compare July 2, 2026 21:33
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/nvskills-ci

@yaoyu-33
yaoyu-33 force-pushed the yuya/remove-perf-configs-h100-recipes branch from 1b83cd7 to 2e71e1c Compare July 2, 2026 21:47
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

/nvskills-ci

@yaoyu-33
fix(recipes): address review comments and unit tests
e1edbd3 
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33
yaoyu-33 force-pushed the yuya/remove-perf-configs-h100-recipes branch from 2e71e1c to e1edbd3 Compare July 2, 2026 21:58
@yaoyu-33

yaoyu-33 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test e1edbd3

@yaoyu-33
test(data): patch canonical llama recipe module
6974758 
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33

yaoyu-33 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 6974758

@yaoyu-33
yaoyu-33 merged commit 4d7ce79 into main Jul 3, 2026
170 checks passed
@yaoyu-33
yaoyu-33 deleted the yuya/remove-perf-configs-h100-recipes branch July 3, 2026 17:53
@pruprakash pruprakash mentioned this pull request Jul 6, 2026
Closed
chochowski pushed a commit to chochowski/Megatron-Bridge that referenced this pull request Jul 21, 2026
@yaoyu-33
refactor(recipes): add h100 recipe namespace (NVIDIA-NeMo#4622)
3fe6c73 
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@cuichenx cuichenx mentioned this pull request Jul 28, 2026
Open
@pruprakash pruprakash mentioned this pull request Aug 23, 2026
Merged
2 of 5 tasks

This branch was previously deployed

2 inactive deployments
public — 6974758b Deployed Jul 3, 2026 by copy-pr-bot[bot] via release / finalize / publish-docs #2176
test — 6974758b Deployed Jul 3, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #17270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuichenx cuichenx cuichenx left review comments
@malay-nagda malay-nagda Awaiting requested review from malay-nagda malay-nagda is a code owner
@erhoo82 erhoo82 Awaiting requested review from erhoo82

Assignees

No one assigned

Labels

area:recipe Training recipes and launch configs breaking-change Public behavior or API compatibility changes feature New capabilities, enhancements, or enablement work full-test-suite needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaoyu-33 @svcnvidia-nemo-ci @cuichenx