refactor(performance): remove legacy perf configs by yaoyu-33 · Pull Request #4623 · NVIDIA-NeMo/Megatron-Bridge

yaoyu-33 · 2026-07-02T05:07:36Z

Summary

Remove the legacy scripts/performance/configs preset tree and dump_perf_configs.py.
Resolve performance launcher workload defaults from flat megatron.bridge.perf_recipes recipes with v2 as the canonical suffix-less variant.
Update perf env plugin/default config variant handling, training-mode inference for legacy lora recipe names, and perf integration/unit tests.

Split

This is the legacy performance config cleanup split out of #4622. #4622 is now recipes-only.

Validation

python3 -m compileall -q scripts/performance scripts/training/run_recipe.py tests/functional_tests/test_groups/recipes/test_perf_config_integration.py tests/unit_tests/scripts/performance tests/unit_tests/recipes/test_override_precedence.py
git diff --check
uvx pre-commit run --all-files

Note: uv run pre-commit run --all-files is blocked on macOS by nvidia-resiliency-ext==0.6.0 Linux-only wheels.

copy-pr-bot · 2026-07-02T05:07:39Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

claude · 2026-07-02T05:16:51Z

Review: refactor(performance): remove legacy perf configs

Solid cleanup. Two blocking issues found; both are guaranteed runtime failures on the paths they touch.

High: _apply_kimi_k2_optimizer does not exist
scripts/performance/utils/utils.py line 533 imports _apply_kimi_k2_optimizer from megatron.bridge.recipes.kimi.kimi_k2, but that module only defines _get_kimi_k2_pipeline_layout and kimi_k2_pretrain_config(optimizer_type=...). Calling get_perf_optimized_recipe with model_recipe_name=kimi_k2 and optimizer_type=adam raises ImportError. This is the exact adam+kimi_k2 override path the block was added for.

High: kimi test imports a symbol the package does not re-export
tests/functional_tests/test_groups/recipes/test_perf_config_integration.py line 192 (test_kimi_flat_perf_recipes_are_parameterless) imports kimi_k2_pretrain_1024gpu_h100_bf16_config from the kimi.h100 package, but perf_recipes/kimi/h100/init.py is header-only and does not re-export it (the function lives in the kimi.h100.kimi_k2 submodule; the family kimi/init.py does re-export it). This test ImportErrors under L0_Launch_recipes_perf_config.sh. Import from kimi.h100.kimi_k2 or perf_recipes.kimi.

Notes

Docs still reference the removed tree: README.md line 16, skills/nemo-mbridge-recipe-recommender/SKILL.md (86, 433), skills/nemo-mbridge-perf-cuda-graphs/SKILL.md (235-237) all point at scripts/performance/configs. Per CONTRIBUTING refactoring rules these stale references should be updated.
_LEGACY_DEFAULT_GPU_COUNTS hardcodes preserved GPU defaults; good that test_get_perf_optimized_recipe_uses_legacy_default_gpu_count locks the DeepSeek H100 case.

Suggested test cases

test_kimi_flat_perf_recipes_are_parameterless (broken import today; must pass once fixed)
test_get_perf_optimized_recipe_uses_legacy_default_gpu_count (add a kimi_k2 optimizer_type=adam case to cover the _apply_kimi_k2_optimizer path)
test_llama3_8b_flat_perf_config_instantiation
test_deepseek_v3_flat_perf_config_instantiation
test_qwen3_30b_flat_perf_config_instantiation
test_precision_config_variations
test_workload_base_config_falls_back_for_gpu_scaling
test_unsupported_legacy_config_variant_errors
test_list_available_config_variants_accepts_legacy_signature
test_get_library_recipe_llama_sets_paths
test_get_library_recipe_deepseek_sets_paths
test_config_overrides_after_precision
test_qwen35_vl_122b_h100_pipeline_layout
test_perf_env_plugin_num_gpus_is_optional
test_set_determinism_env_vars_writes_three_keys

No model_gpu_precision_perf recipe-config functions were modified (only the legacy preset tree was deleted), so no perf launcher cases are impacted beyond L0_Launch_recipes_perf_config.sh.

malay-nagda · 2026-07-02T09:25:27Z

@yaoyu-33 with all the changes, do we now need megatron.core and src (other than perf recipes) on login node to launch jobs?

Before the refactor, we only needed nemo_run on login node to launch jobs which avoided dependency issues on login node.

cc: @gautham-kollu

svcnvidia-nemo-ci · 2026-07-03T00:18:15Z

/nvskills-ci

yaoyu-33 · 2026-07-03T06:12:59Z

@malay-nagda thanks for reminding me, I will double check, this pr not fully ready yet. I will do some proper guarding.

svcnvidia-nemo-ci · 2026-07-03T06:52:45Z

/nvskills-ci

svcnvidia-nemo-ci · 2026-07-03T16:25:46Z

/nvskills-ci

yaoyu-33 · 2026-07-03T16:25:46Z

/ok to test 2bf66ecc2a43501e60caeceb42b703f9837eaf94

copy-pr-bot · 2026-07-03T16:25:50Z

/ok to test 2bf66ecc2a43501e60caeceb42b703f9837eaf94

@yaoyu-33, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

yaoyu-33 · 2026-07-03T16:25:53Z

/ok to test 2bf66ec

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

svcnvidia-nemo-ci · 2026-07-08T22:16:57Z

/nvskills-ci

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

yaoyu-33 · 2026-07-08T22:23:25Z

/ok to test c3556cf

svcnvidia-nemo-ci · 2026-07-08T22:23:33Z

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>

yaoyu-33 · 2026-07-08T23:47:28Z

/ok to test 0f14f15

yaoyu-33 requested review from a team, erhoo82 and malay-nagda as code owners July 2, 2026 05:07

yaoyu-33 mentioned this pull request Jul 2, 2026

refactor(recipes): add h100 recipe namespace #4622

Merged

claude Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread scripts/performance/utils/utils.py

claude Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread tests/functional_tests/test_groups/recipes/test_perf_config_integration.py Outdated

claude Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread scripts/performance/utils/utils.py

claude Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread tests/functional_tests/test_groups/recipes/test_perf_config_integration.py Outdated

malay-nagda requested a review from dingqingy-nv July 2, 2026 09:25

yaoyu-33 force-pushed the yuya/remove-legacy-perf-configs branch from e2497a7 to faf6633 Compare July 3, 2026 00:18

yaoyu-33 changed the base branch from main to yuya/remove-perf-configs-h100-recipes July 3, 2026 00:18

yaoyu-33 force-pushed the yuya/remove-legacy-perf-configs branch from ddde1f0 to 2bf66ec Compare July 3, 2026 16:25

copy-pr-bot Bot temporarily deployed to public July 3, 2026 16:26 Inactive

copy-pr-bot Bot temporarily deployed to test July 3, 2026 16:26 Inactive

yaoyu-33 and others added 9 commits July 8, 2026 15:16

fix(performance): keep legacy workload defaults

a882253

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

fix(performance): keep variant helper signature explicit

8af4f78

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

fix(performance): rename default config variant

3fbc2c4

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

fix(performance): remove legacy variant wording

4472f5b

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

fix(performance): use none for suffixless variant

953671f

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

Attach NVSkills validation signatures

749744d

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>

fix(recipes): use sft and peft task names

86e9563

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

Attach NVSkills validation signatures

9bba375

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>

fix(performance): remove unused plugin GPU count

ad4d73b

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

yaoyu-33 force-pushed the yuya/remove-legacy-perf-configs branch from b5a4de8 to b69936c Compare July 8, 2026 22:16

yaoyu-33 added 3 commits July 8, 2026 15:19

fix(performance): skip recipe lookup for named runs

aa058f8

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

fix(performance): apply recipe env in container

88a7dd4

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

test(performance): align flat recipe unit coverage

c3556cf

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

yaoyu-33 force-pushed the yuya/remove-legacy-perf-configs branch from b69936c to c3556cf Compare July 8, 2026 22:23

copy-pr-bot Bot temporarily deployed to public July 8, 2026 22:23 Inactive

copy-pr-bot Bot temporarily deployed to test July 8, 2026 22:24 Inactive

Attach NVSkills validation signatures

0f14f15

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>

yaoyu-33 mentioned this pull request Jul 9, 2026

[test] fix: Remove online Kimi perf recipe test #4757

Merged

cuichenx mentioned this pull request Jul 28, 2026

[NeMo FW 26.08 Release] MBridge 0.6.0 Roadmap #5144

Open

This was referenced Sep 14, 2026

fix(perf): restore PP=8 for DeepSeek V3 B200 bf16 and fp8_cs recipes #6096

Merged

fix(perf): restore PP=8 for DeepSeek V3 B200 bf16 and fp8_cs recipes #6097

Merged

Conversation

yaoyu-33 commented Jul 2, 2026

Summary

Split

Validation

Uh oh!

copy-pr-bot Bot commented Jul 2, 2026

Uh oh!

Uh oh!

Uh oh!

claude Bot commented Jul 2, 2026

Uh oh!

Uh oh!

Uh oh!

malay-nagda commented Jul 2, 2026

Uh oh!

svcnvidia-nemo-ci commented Jul 3, 2026

Uh oh!

yaoyu-33 commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svcnvidia-nemo-ci commented Jul 3, 2026

Uh oh!

svcnvidia-nemo-ci commented Jul 3, 2026

Uh oh!

yaoyu-33 commented Jul 3, 2026

Uh oh!

copy-pr-bot Bot commented Jul 3, 2026

Uh oh!

yaoyu-33 commented Jul 3, 2026

Uh oh!

svcnvidia-nemo-ci commented Jul 8, 2026

Uh oh!

yaoyu-33 commented Jul 8, 2026

Uh oh!

svcnvidia-nemo-ci commented Jul 8, 2026

Uh oh!

yaoyu-33 commented Jul 8, 2026

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yaoyu-33 commented Jul 3, 2026 •

edited

Loading