Repository navigation
Conversation
|
/ok to test 1613992 |
|
CI request after contributor vetting: please add |
|
Any changes to get this in? It would simplify things a lot on our side! |
|
/ok to test afbe93a |
afbe93a to
c35abb2
Compare
|
/ok to test c35abb2 |
|
Rebased onto current main and fixed the two Qwen3-Omni failures from the first CI run. Local CUDA validation on Transformers 5.14.1 now passes 166 targeted tests across Qwen3-Omni, Qwen3-ASR, Qwen2 Audio, Ministral3, and GLM-5. Ready for another |
Signed-off-by: bvolpato <brunocvcunha@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: bvolpato <brunocvcunha@gmail.com>
c35abb2 to
f3fd952
Compare
|
/ok to test f3fd952 Rebased onto current main and regenerated Validation:
Ready for full L0/L1/L2 CI. |
|
@cuichenx, would you mind taking a look at this Transformers 5.14.1 compatibility update? You handled the previous Transformers bump and have recently worked in both the Qwen3-Omni and GLM paths, so your context would be helpful. If someone else owns this path now, happy to redirect. |
|
Closing as superseded by #5479, which moved the project to Transformers 5.15.0 and included the corresponding Qwen3-Omni and GLM-5 compatibility updates. |
What does this PR do?
Extends Megatron Bridge support from Transformers 5.12.1 through 5.14.1.
Changelog
<=5.12.1to<=5.14.1.uv.lockat Transformers 5.14.1.Why
NovaSky-AI/SkyRL#1974 adds GLM-5.2 config support but limits Transformers to 5.11 because of the Megatron Bridge compatibility range. SkyRL's GLM-5.2 stack works with Transformers 5.14.1, so raising Bridge's upper bound removes that constraint.
Transformers 5.14 also removed
Qwen3OmniMoeAudioEncoder._get_feat_extract_output_lengths. Bridge still called that method, which broke Qwen3-Omni audio forward and its training smoke test. Bridge already has the matching length helper for Qwen3-Omni RoPE, so this PR uses it in the audio path too.GitHub Actions CI
Labels
needs-more-testsandfull-test-suiterequest H100 L0, L1, and L2 coverage against the locked maximum endpoint.Local validation used the NVIDIA PyTorch 26.06 container on an RTX 5070 Ti with CUDA 13.3 and Transformers 5.14.1:
uv lock --checkuv run pre-commit run --all-filesFull GLM-5.2 training and GB200 hardware were not tested locally. GB200 jobs are skipped for external-contributor PR runs, so this PR does not claim GB200 validation.
Before your PR is "Ready for review"
Pre checks:
Additional Information
main.