Repository navigation
Conversation
Signed-off-by: Chen Cui <chcui@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
…-dsv4-library-recipes Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
cuichenx
marked this pull request as ready for review
August 21, 2026 22:22
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
yaoyu-33
previously approved these changes
Aug 28, 2026
weijiac0619
reviewed
Aug 28, 2026
weijiac0619
reviewed
Aug 28, 2026
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
perf_recipesunchangedDeepSeek V4 pretraining requires Megatron-LM
dev. Grouped-FP8 checkpoint saves also require the empty extra-state fix from NVIDIA/Megatron-LM#5997. Until that fix reachesdev, use the equivalent signed commit from NVIDIA/Megatron-LM#6509 on a compatibledevcheckout.Validation
Both runs completed with zero skipped or NaN iterations. The pretraining loss moved from
12.59201to5.960634; packed-SFT loss moved from0.9435847to0.2834835.Additional checks:
298 passed, 1 skippedmainintegrated focused matrix:335 passed, 1 skipped, 1 deselected15 passedmainintegrated branchgit diff --checkand public-diff privacy scan: passedThe deselected metadata test has an unrelated Nemotron 3 Super recipe-name collision that reproduces on current
main; this PR does not modify that metadata or either Nemotron recipe export.Verification scope
The card marks GB200 pretraining and packed SFT verified. Formal checkpoint-resume comparison remains unverified because its contract requires an independent step-50-to-100 run with step-51 and step-100 sentinels. Public post-SFT export/inference, long-context SFT, and the canonical mock-data performance item also remain explicitly unverified.
A capacity-1.5 performance screen was rejected for the library recipe because it dropped more than 64% of expert assignments and routing probability mass. The verified library recipe therefore retains unlimited-capacity natural routing.