Repository navigation
Conversation
Signed-off-by: Chen Cui <chcui@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/nvskills-ci |
Signed-off-by: Chen Cui <chcui@nvidia.com>
yaoyu-33
approved these changes
Aug 14, 2026
yaoyu-33
approved these changes
Aug 14, 2026
cuichenx
enabled auto-merge (squash)
August 14, 2026 18:55
cuichenx
disabled auto-merge
August 14, 2026 19:01
kamran-nvidia
added a commit
that referenced
this pull request
Aug 16, 2026
docs/conf.py copies the repo-root skills/ tree into docs/skills/ at build time, so from docs/training/ the correct relative path is ../skills/... #5570 used ../../skills/..., which resolves outside the Sphinx source tree. Sphinx reports "Unknown source document" and the docs job runs with fail-on-warning: true, so the build fails. This matches the existing convention in docs/training/moe-optimization.md and docs/training/communication-overlap.md, whose builds pass. Signed-off-by: Kamran Jafari <kjafarisadeg@nvidia.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core_attnguidance with an architecture-, backend-, and peak-aware decision table covering every supported recompute labelWhy
The previous guidance generalized a qualitative module ranking from an unmatched Llama experiment. It did not account for architecture-specific boundaries, fused-attention behavior, nested boundaries, runtime compatibility, or the distinction between moving an OOM later and making a workload viable.
Evidence
moe_actreduced peak allocation by 1.85% for a 1.99% step-time cost;mla_up_projreduced it by 1.96% for a 5.19% cost; explicitcore_attnproduced no material memory reduction under fused attention.moewas the smallest tested boundary that completed; addinglayernormrecovered another 1.014 GB at a 3.07% step-time cost. Narrowmoe_actsaved 4.194 GB at the intermediate peak but still OOMed after advancing farther.mlprecovered about 3.2 GB but cost about 16% throughput in the prior unmatched experiment; this is retained only as contextual evidence.The cross-model conclusion is to start with the narrowest architecture-specific boundary responsible for the measured per-rank peak, then broaden only when matched measurements show that it is necessary. There is no universal recompute-module ordering.
Validation
uv run --no-sync pre-commit run --all-filesquick_validate.pygit diff --checkPublication note
The existing
skill.oms.sigbelongs to the previous skill contents. This PR remains draft while a fresh NVSkills evaluation/signature refresh is requested; the historical signature must not be treated as validation of the amended package.