Skip to content

build(deps): AUT-1608 speed up uv lock resolution - #5701

Closed
svcnemo-autobot wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:fix/uv-fht-metadata
Closed

svcnemo-autobot wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:fix/uv-fht-metadata

Conversation

@svcnemo-autobot

Copy link
Copy Markdown
Contributor

Background

uv lock executes the git-sourced fast-hadamard-transform setup metadata path, which imports Torch/CUDA build helpers and makes resolution unexpectedly slow.

What changed

  • Provide static uv metadata for fast-hadamard-transform 1.1.0.
  • Record the metadata in uv.lock.
  • Guard the metadata contract in the dependency-layer test.

Details

flowchart LR
  A[uv resolver] --> B[static dependency metadata]
  B --> C[skip setup.py execution]
  C --> D[fast lock resolution]
Loading

The declared dependencies match the source setup and existing lock entry: torch, packaging, and ninja.

Tested

  • uv lock --check
  • bash .github/scripts/test_docker_dependency_layers.sh
  • uv run --no-sync pre-commit run --all-files
  • Cold resolver: 2m03s before lock update; regenerated resolution: 2.18s; final locked check: 2ms.

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested a review from a team as a code owner August 19, 2026 22:49
@copy-pr-bot

copy-pr-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test 9c42324

@yaoyu-33 yaoyu-33 added area:build Dependencies, packaging, images, and environment setup ci CI, automation, test queue, or workflow infrastructure work needs-review PR is ready for code review and waiting on a reviewer labels Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

All change-relevant checks passed on 9c423243473d3c10f82af09bf8b3c9f97c50d314, including install, lint, copyright, CICD NeMo (unit/H100/GB200), build/release, DCO, secrets, and link checks.

The sole red check is Claude Review pre-flight job 96253092826. It fails at Check NVIDIA SSO membership; the fork-triggered workflow reports Secret source: None, while .github/workflows/claude-review.yml documents that fork pull_request workflows cannot access the secrets/OIDC token required by the review action. An unchanged rerun would therefore be deterministic rather than a flaky retry. Please handle or waive this unrelated workflow check.

@ko3n1g

ko3n1g commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

@svcnemo-autobot fetch and merge upstream main

1 similar comment
@ko3n1g

ko3n1g commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

@svcnemo-autobot fetch and merge upstream main

Copy link
Copy Markdown
Contributor Author

💬 The authoring workstation is starting; I’ll merge the current upstream main into the owned PR branch once it is ready.

@ko3n1g ko3n1g closed this Aug 30, 2026

This branch was previously deployed

2 inactive deployments
public — 9c423243 Deployed Aug 20, 2026 by copy-pr-bot[bot] via release / finalize / publish-docs #4815
test — 9c423243 Deployed Aug 20, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #20790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Dependencies, packaging, images, and environment setup ci CI, automation, test queue, or workflow infrastructure work needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants