Skip to content

build: require tilelang 0.1.9 for ssm - #5733

Merged
malay-nagda merged 1 commit into
mainfrom
codex/fix-tilelang-min-version
Aug 25, 2026
Merged

malay-nagda merged 1 commit into
mainfrom
codex/fix-tilelang-min-version

Conversation

@malay-nagda

Copy link
Copy Markdown
Contributor

What does this PR do ?

Require TileLang 0.1.9 or newer for the optional SSM dependency set and refresh uv.lock.

FLA 0.5.1 dispatches Qwen3.5-VL GDN backward through TileLang. TileLang 0.1.8 bundles a TVM visitor implementation that raises AttributeError: '_NestedLoopCheckVisitor' object has no attribute '_inst'; the fix is included in TileLang 0.1.9.

Changelog

  • Add tilelang>=0.1.9 to the ssm extra.
  • Regenerate uv.lock, selecting TileLang 0.1.13 and Apache TVM FFI 0.1.12.
  • Resolve mamba-ssm to 2.3.1 because 2.3.2.post1 hard-pins the incompatible tilelang==0.1.8.

GitHub Actions CI

This PR is intentionally opened as a draft. Local validation:

  • uv lock --check
  • uv run pre-commit run --all-files

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests? (Dependency metadata only; lock consistency and pre-commit were validated.)
  • Did you add or update any necessary documentation? (No user-facing API or workflow change.)
  • Does the PR affect components that are optional to install? (SSM extra.)
    • Reviewer: Does the PR have correct import guards for all optional libraries? (No import behavior changes.)

Additional Information

Signed-off-by: Malay Nagda <malayn@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@malay-nagda malay-nagda added area:build Dependencies, packaging, images, and environment setup bug Something isn't working labels Aug 21, 2026
@malay-nagda
malay-nagda marked this pull request as ready for review August 25, 2026 03:45
@malay-nagda
malay-nagda requested a review from a team as a code owner August 25, 2026 03:46
@malay-nagda
malay-nagda enabled auto-merge (squash) August 25, 2026 03:46
@claude

claude Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

LGTM. Clean, surgical dependency bump for the ssm extra.

  • pyproject.toml adds tilelang>=0.1.9 to the ssm extra; uv.lock matches (tilelang 0.1.13, apache-tvm-ffi 0.1.12).
  • mamba-ssm correctly downgraded 2.3.2.post1 -> 2.3.1 to escape its tilelang==0.1.8 hard pin (source of the _NestedLoopCheckVisitor._inst AttributeError); the now-unused transitive quack-kernels drops out cleanly.
  • No source/script/docker references to quack-kernels or tilelang, so the removal/bump has no code impact.
  • Dependency added under an optional extra (not required) and submitted standalone (pyproject + uv.lock only), matching the dependency-PR policy.

CI note: only L0 runs by default — add the needs-more-tests label to pull in L1 so the SSM/GDN path that motivated the bump gets exercised.

Suggested test cases:

  • No perf tests impacted (diff touches only pyproject.toml and uv.lock; no scripts/performance/configs/ changes).
  • CI: confirm cicd-container-build succeeds with the refreshed lockfile (validates the mamba-ssm 2.3.1 / tilelang 0.1.13 resolution installs).
  • CI: uv sync --locked --all-extras resolves cleanly (guards against lockfile drift from the removed quack-kernels).

@malay-nagda
malay-nagda merged commit d352ace into main Aug 25, 2026
93 checks passed
@malay-nagda
malay-nagda deleted the codex/fix-tilelang-min-version branch August 25, 2026 06:53

This branch was previously deployed

2 inactive deployments
public — 96e5c3fd Deployed Aug 25, 2026 by copy-pr-bot[bot] via release / finalize / publish-docs #4981
test — 96e5c3fd Deployed Aug 25, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #20961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Dependencies, packaging, images, and environment setup bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants