Skip to content

fix(docs): publish Muse Glimmer verification catalog - #5949

Merged
yaoyu-33 merged 1 commit into
mainfrom
codex/fix-muse-verification-catalog
Sep 3, 2026
Merged

yaoyu-33 merged 1 commit into
mainfrom
codex/fix-muse-verification-catalog

Conversation

@yaoyu-33

@yaoyu-33 yaoyu-33 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • map the Muse Glimmer verification card to a dedicated canonical model guide
  • regenerate the static catalog and Sphinx/Fern model directories
  • add an explicit regression assertion for the Muse guide path

Root cause

PR #5479 added the Muse Glimmer model verification card but did not add its canonical guide mapping or regenerate the catalog outputs. The generator therefore fell back to models/README.md. Main run 33719161485 failed test_models_map_to_canonical_guides on core shard 1 and test_generated_outputs_and_navigation_are_current on core shard 0.

Testing

  • uv run --no-project --with pytest --with pyyaml python -m pytest --confcutdir=tests/unit_tests/doc_consistency tests/unit_tests/doc_consistency/test_model_verification_catalog.py -q
  • uv run --no-project --with pyyaml python skills/create-model-verification-card/scripts/validate_card.py examples/model_verification_cards/muse-glimmer-30b/card.yaml
  • uv run --no-project --with pyyaml python scripts/docs/generate_model_verification_catalog.py --check
  • uv run --no-project --with pre-commit pre-commit run --all-files

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaoyu-33 yaoyu-33 added bug Something isn't working area:misc Cross-cutting utilities, logging, helpers, and other changes needs-review PR is ready for code review and waiting on a reviewer labels Sep 3, 2026
@yaoyu-33

yaoyu-33 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 26ae2df

@claude

claude Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

LGTM — cleanly generated model-verification catalog publication for the Muse Glimmer 30B card; everything is internally consistent.

Verified during review:

  • Inventory counts agree across all generated files: 25 model cards / 358 configurations (was 24/345), i.e. +1 card and +13 entries, exactly the 13 Muse Glimmer entries in catalog-v1.json.
  • Generator additions line up: the meta-models -> Meta owner label and the muse-glimmer-30b -> models/muse_glimmer/muse-glimmer.md page-path mapping match the source card and the new test assertion.
  • Every recipe named in the card commands exists in-tree (muse_glimmer_30b_pretrain_32gpu_h100_bf16_multimodal_config, sft_32gpu_h100_bf16_config, long_context_config, peft_8gpu_h100_bf16_config, and the perf pretrain_32gpu_h100_fp8cs_config).
  • README hrefs follow the established convention (fern without .html, sphinx with .html); the Partial status correctly reflects the single unverified item (checkpoint_resume).
  • Regeneration drift is already guarded by test_generated_outputs_and_navigation_are_current (runs generate check=True), so stale output would fail CI.

Minor note (not a defect): the Benchmark leaf records precision bf16 while the recipe is fp8cs. Defensible — model/gradient state is BF16, FP8 applies only to GEMMs, and fp8_cs is not an allowed precision enum value (bf16/fp8_mx/nvfp4).

Suggested test cases:

  • tests/unit_tests/doc_consistency/test_model_verification_catalog.py::test_models_map_to_canonical_guides
  • tests/unit_tests/doc_consistency/test_model_verification_catalog.py::test_catalog_discovers_every_card_without_a_model_list
  • tests/unit_tests/doc_consistency/test_model_verification_catalog.py::test_generated_outputs_and_navigation_are_current
  • tests/unit_tests/doc_consistency/test_model_verification_catalog.py::test_catalog_is_a_simple_model_directory

No perf tests impacted (no files under scripts/performance/configs/ are touched by this PR).

@yaoyu-33
yaoyu-33 merged commit fea55a0 into main Sep 3, 2026
23 checks passed
@yaoyu-33
yaoyu-33 deleted the codex/fix-muse-verification-catalog branch September 3, 2026 16:06
nemo-autobot-origin Bot pushed a commit to svcnemo-autobot/Megatron-Bridge that referenced this pull request Sep 3, 2026
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
(cherry picked from commit fea55a0)

This branch was previously deployed

1 inactive deployment
test — 26ae2dfb Deployed Sep 3, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #21428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:misc Cross-cutting utilities, logging, helpers, and other changes bug Something isn't working needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant