Skip to content

test(data): AUT-2246 use complete train state in MIMO loader test - #6018

Merged
chtruong814 merged 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:fix/mimo-loader-train-state-fixture
Sep 8, 2026
Merged

chtruong814 merged 1 commit into
NVIDIA-NeMo:mainfrom
svcnemo-autobot:fix/mimo-loader-train-state-fixture

Conversation

@svcnemo-autobot

Copy link
Copy Markdown
Contributor

Background

Launch_Unit_Tests_Core_2 failed after #5525 because its new canonical-grid test supplied an incomplete mock training state. The loader reads consumed_valid_samples, but the mock defined only consumed_train_samples.

What changed

Use the real TrainState fixture, whose train and validation sample counters both default to zero.

Details

This keeps the test aligned with the loader's declared TrainState contract and allows it to reach the canonical sampler behavior it intends to verify. Production behavior is unchanged.

Tested

  • Launch_Unit_Tests_Core@2/3: 3,301 passed, 5 skipped
  • Ruff check and format check on the changed file
  • Full pre-commit could not run locally because the typed authoring checkout does not expose Git metadata inside the validation workstation; GitHub CI remains authoritative

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test c626c09

@chtruong814
chtruong814 merged commit 7e3678e into NVIDIA-NeMo:main Sep 8, 2026
64 of 65 checks passed

This branch was previously deployed

1 inactive deployment
test — c626c09d Deployed Sep 8, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #21595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants