Repository navigation
test(data): AUT-2246 use complete train state in MIMO loader test - #6018
Merged
chtruong814 merged 1 commit intoSep 8, 2026
Merged
chtruong814 merged 1 commit into
chtruong814 merged 1 commit into
Conversation
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Contributor
|
/ok to test c626c09 |
chtruong814
approved these changes
Sep 8, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Launch_Unit_Tests_Core_2failed after #5525 because its new canonical-grid test supplied an incomplete mock training state. The loader readsconsumed_valid_samples, but the mock defined onlyconsumed_train_samples.What changed
Use the real
TrainStatefixture, whose train and validation sample counters both default to zero.Details
This keeps the test aligned with the loader's declared
TrainStatecontract and allows it to reach the canonical sampler behavior it intends to verify. Production behavior is unchanged.Tested
Launch_Unit_Tests_Core@2/3: 3,301 passed, 5 skipped