Repository navigation
feat(model): add Nemotron 3.5 Super VL support - #6100
Merged
Merged
Conversation
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Use the HF/vLLM source-timeline prompt unconditionally and remove the legacy prompt-mode switch. Add the copyright header required by CI for the new video utility test. Signed-off-by: Chen Cui <chcui@nvidia.com>
Use the processor-owned video grid and actual per-tubelet vision token counts in the shipped inference examples. Reuse the training prompt labels so inference preserves source timestamps without adding a legacy video prefix. Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
cuichenx
marked this pull request as draft
September 18, 2026 19:46
Retain both Bagel and Nemotron 3.5 Super VL forward-step registrations. Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Add an opt-in shared backend for training, conversion and inference when site-managed Pyxis runtime placement cannot meet storage requirements. Preserve Pyxis defaults and worker semantics, validate Lustre storage and effective Enroot settings, and cover generated wrappers with focused tests. Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Merge upstream/main, regenerate both model indexes, preserve the derived RADIO summary buffer on strict re-export, and honor forwarded HF cache roots in direct Enroot. Signed-off-by: Chen Cui <chcui@nvidia.com>
cuichenx
marked this pull request as ready for review
September 21, 2026 17:56
Contributor
Author
|
/ok to test b049c95 |
Signed-off-by: Chen Cui <chcui@nvidia.com>
Contributor
|
Light review — LGTM Reviewed the diff against the mandatory workflow (read diff, loaded adding-model-support + review-pr skills, then reviewed). Scope: critical bugs/logic, typos, test coverage, doc accuracy. No blocking issues found. Notes on the one item I chased down:
Suggested test cases No perf tests impacted (no scripts/performance/configs/ targets touched by this PR). Unit cases exercised/derived from the diff (all present in the PR, listed for the record):
|
5 of 7 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds Megatron Bridge support for Nemotron 3.5 Super VL, combining the Nemotron 3 Super language/MTP stack with the shared Nemotron Omni image and temporal-video stack, without an audio encoder.
The Bridge translates one serialized HF MTP block into two repeated Megatron prediction depths and preserves the HF block count on export. This PR is ready for code review; current-head model verification is still being refreshed and is not a merge-readiness claim.
Changelog
NemotronH_Omni_Reasoning_V3and normalize its hybrid/MTP configuration through the shared Nemotron-H bridge.recipes/, with independent language, vision, and projector freeze controls.main, including its pinned-HF-revision loader fix, and regenerate the model indexes to retain both branches' entries.GitHub Actions CI
See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
Additional Information
HF_HOMEand explicit cache overrides. Four export regression cases passed an isolated CPU check using the real strict safetensors writer; full conversion-test collection still requires the model runtime dependencies.mainand this branch:test_known_cross_package_collisions_have_explicit_benchmark_precedencereports the existingnemotron_3_super_pretrain_64gpu_gb200_bf16_configname collision. This unrelated base failure is not patched in the model-addition PR.