Skip to content

feat(nemotron): Add GTP + partial CG + cuDNN LN support for NT3 Ultra MXFP8 GB200/GB300/VRNVL72 recipes - #6228

Merged
malay-nagda merged 18 commits into
NVIDIA-NeMo:mainfrom
ghadiaravi13:rghadia/nt3-ultra-gtp-cg
Oct 13, 2026
Merged

malay-nagda merged 18 commits into
NVIDIA-NeMo:mainfrom
ghadiaravi13:rghadia/nt3-ultra-gtp-cg

Conversation

@ghadiaravi13

@ghadiaravi13 ghadiaravi13 commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do ?

Adds GTP + partial CG support to NT3 Ultra MXFP8 GB200/GB300/VRNVL72 recipes
Also enables cuDNN Layernorm for both GB200 and GB300 recipes.

The GB200/VRNVL72 configs are also updated with NCCLEP support

Changelog

  • Partial CUDA graph for NT3 Ultra MXFP8 GB200/GB300/VRNVL72 recipes
  • Added GTP sharding for the moe_latent_proj module in Nemotron 3 Ultra GB200 configuration.
  • Implemented local CUDA graph handling in training and validation processes.
  • Updated tests to ensure proper validation of local per-layer CUDA graph modules.
  • Updated Rubin tests to match with the new GB300 config
  • Improved error handling for unsupported local whole-layer captures.

GitHub Actions CI

See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

rghadia added 5 commits September 26, 2026 11:10
…nd GB300

- Introduced `_apply_nemotron_3_ultra_gtp` function to configure GTP settings for dense weight sharding.
- Updated `nemotron_3_ultra_pretrain_256gpu_gb200_fp8mx_config` and `nemotron_3_ultra_pretrain_256gpu_gb300_fp8mx_config` to apply GTP settings.
- Added support for GTP sharding in the `moe_latent_proj` module to address memory pressure.

Signed-off-by: Ravi Ghadia <rghadia@nvidia.com>
Signed-off-by: Ravi Ghadia <rghadia@nvidia.com>
Signed-off-by: Ravi Ghadia <rghadia@nvidia.com>
- Partial CUDA graph for NT3 Ultra MXFP8 GB200/GB300 recipes
- Added GTP sharding for the `moe_latent_proj` module in Nemotron 3 Ultra GB200 configuration.
- Implemented local CUDA graph handling in training and validation processes.
- Updated tests to ensure proper validation of local per-layer CUDA graph modules.
- Improved error handling for unsupported local whole-layer captures.

Signed-off-by: Ravi Ghadia <rghadia@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cuichenx cuichenx added feature New capabilities, enhancements, or enablement work area:recipe Training recipes and launch configs labels Sep 28, 2026
…into rghadia/nt3-ultra-gtp-cg

Signed-off-by: rghadia <rghadia@nsc-lhr-slurm-1-vscode-01.nvidia.com>
@ghadiaravi13 ghadiaravi13 changed the title feat(nemotron): Add partial CG support for NT3 Ultra MXFP8 GB200/GB300 recipes feat(nemotron): Add GTP + partial CG support for NT3 Ultra MXFP8 GB200/GB300 recipes Oct 9, 2026
@ghadiaravi13
ghadiaravi13 marked this pull request as ready for review October 9, 2026 23:04
@cuichenx cuichenx added the needs-review PR is ready for code review and waiting on a reviewer label Oct 9, 2026
- Changed references from HybridEP to NCCLEP in both GB200 and GB300 configurations.
- Added support for cuDNN normalization kernels in both configurations.
- Enabled NCCLEP and adjusted expert token handling in GB200.
- Commented out the HSDP/FSDP dtype overrides in GB300 for clarity.

These changes enhance the performance and compatibility of the Nemotron 3 Ultra pretraining setups.

Signed-off-by: rghadia <rghadia@nvidia.com>
@ghadiaravi13 ghadiaravi13 changed the title feat(nemotron): Add GTP + partial CG support for NT3 Ultra MXFP8 GB200/GB300 recipes feat(nemotron): Add GTP + partial CG + cuDNN LN support for NT3 Ultra MXFP8 GB200/GB300 recipes Oct 9, 2026
malay-nagda
malay-nagda previously approved these changes Oct 10, 2026
@malay-nagda

Copy link
Copy Markdown
Contributor

/ok to test 24cb4f9

@github-actions

Copy link
Copy Markdown
Contributor

Automatic Claude reviews have been retired. To request a pull-request review, post a comment containing:

/review

Add model=claude to use a Claude reviewer (the default is model=codex). mode=light|strict selects the review depth; for example, /review model=claude mode=strict. Comment /review help for all options.

Signed-off-by: rghadia <rghadia@nvidia.com>
…00 recipe

Signed-off-by: rghadia <rghadia@nsc-lhr-slurm-1-vscode-01.nvidia.com>
@ghadiaravi13

Copy link
Copy Markdown
Contributor Author

/ok to test 39c25c6

@copy-pr-bot

copy-pr-bot Bot commented Oct 11, 2026

Copy link
Copy Markdown

/ok to test 39c25c6

@ghadiaravi13, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@ghadiaravi13

Copy link
Copy Markdown
Contributor Author

/ok to test 39c25c6

- Replaced HybridEP references with NCCLEP in GB300 and Rubin configurations.
- Moved NCCLEP to the base recipe constructor so that Rubin recipe can pick up the NCCLEP changes
- Updated test cases to reflect changes in execution layout and environment variables.
- Improved clarity in comments regarding NCCL EP settings.

These modifications enhance the performance and compatibility of the Nemotron 3 Ultra pretraining setups.

Signed-off-by: rghadia <rghadia@nvidia.com>
@ghadiaravi13 ghadiaravi13 changed the title feat(nemotron): Add GTP + partial CG + cuDNN LN support for NT3 Ultra MXFP8 GB200/GB300 recipes feat(nemotron): Add GTP + partial CG + cuDNN LN support for NT3 Ultra MXFP8 GB200/GB300/VRNVL72 recipes Oct 12, 2026
@ghadiaravi13

Copy link
Copy Markdown
Contributor Author

/ok to test 892a800

- Removed "moe_router" from the set_cuda_graph_modules function calls in both GB200 and GB300 configurations.
- Added a TODO comment to indicate the need for this change due to MCore PR 7046, which affects CPU-to-GPU copy for per token loss.

Signed-off-by: rghadia <rghadia@nvidia.com>
Signed-off-by: Ravi Ghadia <rghadia@nvidia.com>
@malay-nagda

Copy link
Copy Markdown
Contributor

/ok to test b892a0e

malay-nagda
malay-nagda previously approved these changes Oct 13, 2026
@malay-nagda
malay-nagda requested a review from cuichenx October 13, 2026 04:43
@malay-nagda

Copy link
Copy Markdown
Contributor

@cuichenx can you take a look too since it touches src code?

Signed-off-by: rghadia <rghadia@nvidia.com>
…avi13/NT3-Ultra-Megatron-Bridge into rghadia/nt3-ultra-gtp-cg

Signed-off-by: rghadia <rghadia@nvidia.com>
@ghadiaravi13

Copy link
Copy Markdown
Contributor Author

/ok to test cbd1d28

…into rghadia/nt3-ultra-gtp-cg

Signed-off-by: rghadia <rghadia@nvidia.com>
Signed-off-by: rghadia <rghadia@nvidia.com>
@ghadiaravi13

Copy link
Copy Markdown
Contributor Author

/ok to test 065e181

@malay-nagda malay-nagda added the r0.7.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. label Oct 13, 2026
@malay-nagda
malay-nagda merged commit 2eca468 into NVIDIA-NeMo:main Oct 13, 2026
85 checks passed
malay-nagda added a commit that referenced this pull request Oct 13, 2026
#6437)

Signed-off-by: Ravi Ghadia <rghadia@nvidia.com>
Signed-off-by: Malay Nagda <malayn@nvidia.com>
Co-authored-by: Ravi Ghadia <40660742+ghadiaravi13@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
test — 065e1812 Deployed Oct 13, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #22812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:recipe Training recipes and launch configs feature New capabilities, enhancements, or enablement work needs-review PR is ready for code review and waiting on a reviewer r0.7.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants