Repository navigation
feat(conversion): add a failure exit mode to HF/Megatron comparison - #6312
Open
yuchenwang3 wants to merge 3 commits into
Open
yuchenwang3 wants to merge 3 commits into
yuchenwang3 wants to merge 3 commits into
Conversation
Author
|
@cuichenx Could you review the opt-in |
cuichenx
previously approved these changes
Oct 9, 2026
Contributor
|
/ok to test 2153756 |
Contributor
|
Automatic Claude reviews have been retired. To request a pull-request review, post a comment containing: Add |
Assisted-by: OpenAI Codex Signed-off-by: Yuchen Wang <93700456+yuchenwang3@users.noreply.github.com>
Assisted-by: OpenAI Codex Signed-off-by: Yuchen Wang <93700456+yuchenwang3@users.noreply.github.com>
yuchenwang3
force-pushed
the
fix/compare-failure-exit
branch
from
October 9, 2026 21:59
7ebb0ad to
bb4937a
Compare
cuichenx
previously approved these changes
Oct 10, 2026
Contributor
|
/ok to test bb4937a |
Mock scheduler selection instead of bypassing the Megatron forward helper. Drive the real inference wrapper, iterator, and forward-step callback with a single-microbatch test scheduler, then assert the scheduling and model input contracts. Preserve the existing offline AutoConfig fixture. Assisted-by: OpenAI Codex Signed-off-by: Yuchen Wang <eang333cms@gmail.com>
yuchenwang3
force-pushed
the
fix/compare-failure-exit
branch
from
October 12, 2026 18:25
1bd9164 to
12a6ab7
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
--fail-on-mismatchto the HF/Megatron forward comparison. Today a different next token or cosine similarity below 0.99 is printed, but the command still exits successfully. The new flag makes those cases fail the command, so a validation job can use its exit status.Changelog
Validation
Local test command (isolates the CPU test file from GPU-dependent conftest imports):
GitHub Actions CI
External contributor; NVIDIA runner approval is needed for CI.
Before your PR is ready for review
Additional Information
Implementation and tests were written with OpenAI Codex.