Repository navigation
chore: AUT-2517 bump MCore main to fde43b6d - #6405
Merged
ko3n1g merged 2 commits intoOct 11, 2026
Merged
Conversation
Pin .main.commit and the 3rdparty/Megatron-LM gitlink to NVIDIA/Megatron-LM main fde43b6d617752433310b4668c6b5c55e503521a and regenerate uv.lock with uv 0.7.2 (uv lock --upgrade). .dev.commit is unchanged. Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
MCore fde43b6d (via #7469) makes process_mtp_loss read config.attention_cp_layout. Mirror TransformerConfig's default ('zigzag') in the SimpleNamespace stub used by test_process_mtp_loss_with_native_packing_metadata.
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Contributor
|
/ok to test fcdb71f |
Contributor
|
Automatic Claude reviews have been retired. To request a pull-request review, post a comment containing: Add |
ko3n1g
enabled auto-merge (squash)
October 11, 2026 11:43
ko3n1g
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Nightly Megatron-Core bump (main lane). Moves
.main.commitand the3rdparty/Megatron-LMgitlink from 8949def8 to fde43b6d (NVIDIA/Megatron-LMmain)..dev.commitis unchanged (4a4de865).What changed
.main.commitand the gitlink now point tofde43b6d617752433310b4668c6b5c55e503521a.uv.lockwithuv lock --upgrade(uv 0.7.2, matchingUV_VERSION). MCore'spyproject.tomlis identical at both pins, so the dependency metadata needed no change. Six packages moved: grpcio/grpcio-tools 1.85.0rc1 (prereleases are allowed), httptools 0.9.0, openai 3.28.0, pycparser 3.11 and ruff 0.17.0.process_mtp_lossreadconfig.attention_cp_layout.test_process_mtp_loss_with_native_packing_metadatanow sets it to"zigzag", TransformerConfig's default, in itsSimpleNamespacestub. Nothing in Bridgesrc/callsprocess_mtp_loss.Details
The tests were chosen from the MCore diff (MoE/flex dispatch, MLA, MTP, DSv4, checkpointing). The diffusion unit row was excluded because none of its code uses the changed paths.
Tested
Run locally on H100 (2 GPUs per row) with a validation image built from this head:
L0_Launch_recipes_deepseekwas excluded on maintainer instruction. Its DeepSeek-V4 toy model is missing from the test data, so it ran zero tests.