Repository navigation
[build] chore: bump MCore main to e30d863a - #6414
Merged
cuichenx merged 3 commits intoOct 12, 2026
Merged
Conversation
Signed-off-by: Chen Cui <chcui@nvidia.com>
Contributor
|
Automatic Claude reviews have been retired. To request a pull-request review, post a comment containing: Add |
Signed-off-by: Chen Cui <chcui@nvidia.com>
cuichenx
deleted the
chcui/mb-chores/bump-mcore-main-20261012-full-e30d863
branch
October 12, 2026 20:40
ZhiyuLi-Nvidia
pushed a commit
to ZhiyuLi-Nvidia/Megatron-Bridge
that referenced
this pull request
Oct 13, 2026
Signed-off-by: Chen Cui <chcui@nvidia.com>
nemo-autobot-origin Bot
pushed a commit
to svcnemo-autobot/Megatron-Bridge
that referenced
this pull request
Oct 13, 2026
…-261012-main Upstream main landed NVIDIA-NeMo#6414 (MCore main e30d863a). Resolve the .main.commit conflict to the session pin a98aed553e25b4e86c59f50be54ac0ea4227b442; the 3rdparty/Megatron-LM gitlink fast-forwards to the same commit. Keep the session uv lock --upgrade output (pyproject.toml is identical on both sides); uv lock --check passes on the merged tree. Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advance the MCore main pin and submodule from
e0c5e18673bf4d4fd89cf87c4f1afbe521fe297ftoe30d863a6d82a3c45f2d71355dc73fbf5610967b, and align Bridge's static Transformer Engine metadata and generated lock with the new upstream TE revision..dev.commitis unchanged.Upstream comparison includes request-local sampling seeds (#7828, optional with a
Nonedefault) and the TE revision update (#8036).Cause classification 2. No bug on either side, just incompatibility: #8036 intentionally advances TE from
6ea2a74ato44f31bbe; Bridge's static metadata must follow it to avoid assigning the old version to the new source. The metadata consistency check fails before the adaptation and passes afterward. No Bridge runtime code changes are included.Validation: Linux/CUDA
uv lockanduv lock --checkpass (345 packages), TE source/version and upstream metadata agree, all-file pre-commit andgit diff --checkpass, main pin/gitlink match, and the dev pin and Bridge dependency overrides remain unchanged. Independent review found no blocking issues. The generated lock also normalizes markers inside packages already excluded bysys_platform == 'never'and their unreachable dependency subtree; these have no effective dependency change. Lock format remains unchanged.Requested CI: full L0/L1/L2, preserving the midnight request and both tier labels. Current head
5f033e60fc947bb8c9d54813518964cccf029772incorporates the landed base repairs #6416 and #6420. The original four-file bump diff and MCore pin remain unchanged.Current-head CICD NeMo run 38278795439, attempt 1 passed: all four unit jobs and all 119 functional jobs, covering H100 L0/L1/L2 (30/26/17) and GB200 L0/L1/L2 (12/21/13). Configure outputs confirm
needs_more_tests=true,full_test_suite=true,expect_l1=true, andexpect_l2=true.Standard gates are not yet all green: wheel/release is pending, and link check attempt 2 is running after a scoped retry. Attempt 1 reported only GitHub HTTP503 errors (37 occurrences); a representative failed URL now returns HTTP200. This is transient infrastructure, with no upstream MCore cause category.
The earlier GB200 config-lock permission failure came from base Bridge #6162, independently reproduced on base main and fixed by #6420. The earlier historical documentation failure was repaired by #6416. Neither was caused by MCore; the upstream cause taxonomy does not apply to these unrelated base defects.
The TE metadata/lockfile changes require current-head human approval before merge. Functional full-suite success is verified; overall CI readiness remains pending the standard gates above.