Repository navigation
refactor(recipe)!: rename vr200 GPU type and perf recipes to vrnvl72 - #6419
Merged
Merged
Conversation
Vera Rubin NVL72 systems are now identified as vrnvl72. Rename the vr200 perf recipe packages and their 53 recipe functions, and use vrnvl72 for the GPU map, the 4752 MHz memory-clock default, NUMA, override and topology handling, docs and tests. --gpu vr200 and _vr200_ benchmark recipe names stay accepted as deprecated aliases that log a warning on the launcher and global rank 0, so existing callers keep working during the deprecation window. Code that imports the old Python names directly must update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Malay Nagda <malayn@nvidia.com>
Contributor
|
Automatic Claude reviews have been retired. To request a pull-request review, post a comment containing: Add |
balasaajay
approved these changes
Oct 12, 2026
malay-nagda
added a commit
that referenced
this pull request
Oct 13, 2026
ksivaman
added a commit
to ksivaman/Megatron-Bridge
that referenced
this pull request
Oct 13, 2026
Resolve conflicts with the vr200 -> vrnvl72 rename (NVIDIA-NeMo#6419): rename the 4-GPU DeepSeek V3 proxies to deepseek_v3_pretrain_4gpu_vrnvl72_{fp8mx,nvfp4}_proxy_config and update their tests and recipe lists. Follow NVIDIA-NeMo#6282 and set NVTE_ALLOW_NONDETERMINISTIC_ALGO=0 in both 4-GPU proxies to match their 256-GPU VRNVL72 parents and the environment invariant test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Renames the Vera Rubin NVL72 GPU type from
vr200tovrnvl72in the performance recipes and launchers.vr200stays a deprecated CLI alias so existing callers keep working while they move over.Changelog
src/megatron/bridge/perf_recipes/<family>/vr200/to.../vrnvl72/for the 7 families (deepseek, gpt_oss, kimi, llama, nemotronh, qwen, qwen_vl) and the 53*_vr200_*recipe functions to*_vrnvl72_*. Family__init__exports,dump_perf_configs.py, docstrings, READMEs and tests follow.vrnvl72:NUM_GPUS_PER_NODE_MAP, the 4752 MHz--peak_mem_clkdefault, the NUMA divisor, override and topology sets, and the training launcher's hardware check.--gpu vr200is mapped tovrnvl72by an argparsetype=callable (LEGACY_GPU_ALIASESinscripts/performance/argument_parser.py). Onlyvrnvl72is listed in the choices and help. The deprecation warning is logged on the launcher and global rank 0 only, because every rank re-parses the forwarded argv._vr200_resolves to the renamed_vrnvl72_recipe, with a warning, when that recipe exists (LEGACY_HARDWARE_ALIASESinscripts/training/recipe_metadata.py).tests/unit_tests/scripts/performance/test_argument_parser.py.test_recipe_metadata.py,test_recipe_runner.pyandtest_setup_experiment.py.--gpu vr200. It asserts the canonical experiment name and the4752,4752memory-clock lock.Breaking change (Python API only). Code that imports the old names directly must update:
megatron.bridge.perf_recipes.<family>.vr200.*→megatron.bridge.perf_recipes.<family>.vrnvl72.*;*_vr200_*_config→*_vrnvl72_*_config;gpu="vr200"to script helpers without argparse, andNUM_GPUS_PER_NODE_MAP["vr200"].Nothing in this repo imports the old names. The CLI keeps accepting
--gpu vr200and_vr200_recipe names during the deprecation window. Removing the alias later means deleting the two alias tables (each comment points to the other), the help and README notes, and the alias test cases.Validation
check,--select I,format --check): clean on all 56 changed Python files.--noconftest: 138 passed, 1 failed intests/unit_tests/scripts/performance/test_argument_parser.pyandtests/unit_tests/scripts/training/{test_recipe_metadata,test_recipe_runner,test_setup_experiment}.py.test_known_cross_package_collisions_have_explicit_benchmark_precedence, also fails onmain.tests/unit_tests/scriptsis excluded from CI collection (norecursedirs), so these tests ran locally only.vrnvl72names and novr200names;dump_perf_configs.pycombinations resolve;__init__import resolves.--gpu vrnvl72and--gpu vr200both resolve to the same existing*_vrnvl72_*recipes. The renamed recipe bodies are unchanged apart from the name.GitHub Actions CI
See the CI section in the Contributing doc for how to trigger the CI.
Before your PR is "Ready for review"
Pre checks:
Additional Information
--gpu vr200until its own rename lands, and the alias covers that period.🤖 Generated with Claude Code