Repository navigation
ci: use writable config locks for offline test containers - #6420
Merged
Merged
Conversation
Signed-off-by: Chen Cui <chcui@nvidia.com>
Contributor
|
Automatic Claude reviews have been retired. To request a pull-request review, post a comment containing: Add |
nemo-autobot-origin Bot
pushed a commit
to svcnemo-autobot/Megatron-Bridge
that referenced
this pull request
Oct 13, 2026
Bring in d8fe0b5 (NVIDIA-NeMo#6420, ci: use writable config locks for offline test containers) so this PR's CI uses a writable MEGATRON_CONFIG_LOCK_DIR. The merged tree is identical to the locally validated merge(ce1b60a, a2e8061). Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
After #6162 moved configuration locks into
HF_HOME, the unprivileged GB200 test container cannot create them in the shared offline model cache. This blocks main and #6414 before model loading. Main failure and bump failure both report the same lock-file permission error.For functional jobs mounting the offline cache, pass the existing
MEGATRON_CONFIG_LOCK_DIRoverride to the writable container cache. Every rank in these single-container jobs shares that directory. The shared model cache remains offline; the library default and unit-test configuration are unchanged. This preserves #6162's shared-directory default for multi-node users.This is a base CI integration failure introduced by Bridge #6162, independent of the MCore bump. No upstream Megatron-LM PR causes it; the MCore cause taxonomy does not apply.
Validation
safe_load_config_with_retry,AutoConfig, andFileLockwith an offline local fixture and effective UID 1000: unwritable cache reproduces the permission failure; a writable lock override succeeds.git diff --checkpass. Independent review found no blocking findings.