Skip to content

docs(model): re-verify Nemotron 3.5 Lightning training at a recipe-containing revision - #6425

Merged
cuichenx merged 2 commits into
mainfrom
pruprakash/fix_card_lightning_training_pins
Oct 13, 2026
Merged

cuichenx merged 2 commits into
mainfrom
pruprakash/fix_card_lightning_training_pins

Conversation

@pruprakash

Copy link
Copy Markdown
Contributor

What does this PR do ?

Fixes two problems in the Nemotron 3.5 Lightning verification card's training items.

  1. The training leaves were pinned to bridge_commits that predate the recipe rename in [recipes] refactor: standardize Nemotron 3.5 Lightning naming #5303, so the recipes named in the published commands did not exist at the recorded revision. The card's default bridge_commit moves to bcd2d13 ([recipes] refactor: standardize Nemotron 3.5 Lightning naming #5303). Conversion and inference stay at 619a2df with explicit pins, and the per-leaf training pins are dropped. Every verified training leaf is re-run in nvcr.io/nvidia/nemo:26.08 at bcd2d13 (2x8 H100, 2x4 GB200), and its metrics and expected result are replaced with the measured values.
  2. The published two-node H100 sft_long_context command runs out of memory in iteration 2 on H100 80GB. The leaf now runs on four eight-GPU nodes. Recipe GBS/MBS, sequence length, TP/CP/EP, recompute and precision are unchanged. It was re-verified on 4x8 H100 at bcd2d13 (100/100 steps, LM loss 0.4268879 -> 0.2653436), and the audited token-slot fixture is updated to 32 GPUs.

Catalog, nightly MDX and model guide are regenerated from the card.

Changelog

  • examples/model_verification_cards/nemotron-3.5-lightning/card.yaml: default bridge_commit -> bcd2d134c; QA-measured metrics, last_verified and expected results for every training leaf on H100 and GB200; H100 sft_long_context on 4 nodes; summary updated.
  • docs/_static/model-verification/catalog-v1.json, docs/models/nemotron/nemotron3.5-lightning.md, docs/fern/.../nemotron3.5-lightning.mdx: regenerated.
  • tests/unit_tests/doc_consistency/test_verification_card_recipe_revisions.py (new): each verified Lightning leaf's recipe is defined under src/ at its effective bridge_commit, and its last_verified is no earlier than that commit's date.
  • tests/unit_tests/skills/create_model_verification_card/test_validate_card.py: H100 sft_long_context audited GPU count 16 -> 32.

Additional Information

  • QA runs: nvcr.io/nvidia/nemo:26.08, Bridge bcd2d134c, MCore 6513e3e2; H100 on EOS (jobs 6223620-6223626, 6223752, 6239236), GB200 on 2x4 nodes (jobs 3289307-3289313, 3289316, 3289411, 3289412, 3290217, 3318807). All leaves 0 skipped / 0 NaN, checkpoints complete.

  • Metrics: card skill definitions, parsed from complete optimizer-step rows; last-10-step means.

  • This new test skips in CI. It needs the recorded commits in git history, and CI's depth-1 checkout does not have them; it skips only in a shallow checkout, and a missing commit fails in a full clone. Run it locally with full history. It fails on the current main card and passes here.

  • peak_*_memory_gib values are as reported by Megatron, which uses GB (1e9 bytes) despite the field name; left unchanged here.

  • Checks: validate_card.py valid; generate_model_verification_catalog.py --check clean; tests/unit_tests/doc_consistency + test_validate_card.py pass; pre-commit clean.

  • NVBug: 6626551, 6900116.

…ntaining revision

The Lightning card's training leaves were pinned to bridge_commits that
predate the recipe rename in #5303, so the recipes named in their
published commands did not exist at the recorded revision.

Move the card default bridge_commit to bcd2d13 (#5303), keep the
conversion and inference items at 619a2df with explicit pins, drop the
per-leaf training pins, and replace the re-run training leaves' metrics
and expected results with values measured in nvcr.io/nvidia/nemo:26.08 at
bcd2d13 on 2x8 H100 and 2x4 GB200. The H100 long-context SFT leaf is
re-run in the following commit.

Add a doc-consistency test that each verified Lightning recipe exists at
the revision its leaf records.

Signed-off-by: Pruthviraj Prakash <pruprakash@nvidia.com>
… nodes

The published two-node H100 sft_long_context command runs out of memory
in iteration 2 on H100 80GB at the card's recipe-containing revision, so
the leaf was never reproducible. Four nodes halve the distributed
optimizer shard without changing the convergence contract (recipe GBS/MBS,
sequence length, TP/CP/EP, recompute and precision are unchanged).

Re-verify the leaf on nvcr.io/nvidia/nemo:26.08 at bcd2d13, record the
measured metrics, update the audited token-slot fixture to 32 GPUs, and
state in the card summary that every verified training leaf was measured
at the card's bridge_commit.

Extend the recipe-revision test to require each verified leaf's
last_verified date to be no earlier than its bridge_commit's commit date.

Signed-off-by: Pruthviraj Prakash <pruprakash@nvidia.com>
@pruprakash pruprakash self-assigned this Oct 12, 2026
@pruprakash pruprakash added docs Documentation-only updates or documentation debt area:model Model implementations and HF bridge logic needs-review PR is ready for code review and waiting on a reviewer qa_rcca_done labels Oct 12, 2026
@copy-pr-bot

copy-pr-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cuichenx cuichenx added the r0.7.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. label Oct 13, 2026
@cuichenx

Copy link
Copy Markdown
Contributor

/ok to test 659355b

@cuichenx
cuichenx enabled auto-merge (squash) October 13, 2026 00:58
@cuichenx cuichenx added ready-to-merge PR is approved, current, and only waiting for CI to pass before merge and removed needs-review PR is ready for code review and waiting on a reviewer labels Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automatic Claude reviews have been retired. To request a pull-request review, post a comment containing:

/review

Add model=claude to use a Claude reviewer (the default is model=codex). mode=light|strict selects the review depth; for example, /review model=claude mode=strict. Comment /review help for all options.

@github-actions

Copy link
Copy Markdown
Contributor

@pruprakash
pruprakash requested a review from cuichenx October 13, 2026 01:36
@cuichenx
cuichenx merged commit 08ab678 into main Oct 13, 2026
121 of 123 checks passed
@cuichenx
cuichenx deleted the pruprakash/fix_card_lightning_training_pins branch October 13, 2026 20:04

This branch was successfully deployed

1 active deployment
test — 659355b3 Deployed Oct 13, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #22799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:model Model implementations and HF bridge logic docs Documentation-only updates or documentation debt qa_rcca_done r0.7.0 Auto-cherrypick to release branch. Apply before merge; cherrypick happens after merge. ready-to-merge PR is approved, current, and only waiting for CI to pass before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants