Repository navigation
build: install cudnn-frontend from feat/1.29.0-megatron in fw_final image - #6427
Open
ZhiyuLi-Nvidia wants to merge 3 commits into
Open
ZhiyuLi-Nvidia wants to merge 3 commits into
ZhiyuLi-Nvidia wants to merge 3 commits into
Conversation
ZhiyuLi-Nvidia
added
the
area:build
ZhiyuLi-Nvidia
changed the title
cuichenx
added
the
ci
balasaajay
previously approved these changes
Oct 13, 2026
balasaajay
added
26.10
r0.7.0
balasaajay
marked this pull request as ready for review
October 13, 2026 05:15
ZhiyuLi-Nvidia
dismissed
balasaajay’s stale review
October 13, 2026 05:20
The base branch was changed.
Signed-off-by: Chen Cui <chcui@nvidia.com>
Add CUDNN_FRONTEND_GIT_REF build arg to Dockerfile.ci, pinned to the feat/1.29.0-megatron tip. It is installed over the locked wheel after the final uv sync and skipped when PRESERVE_BASE_RUNTIME=True. Docker-only, outside pyproject.toml and uv.lock. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
…fw_final fw_final inherits the Bridge image and re-syncs with fw_pyproject.toml, which would replace a git install made earlier. Install the feat/1.29.0-megatron ref after that sync instead, and drop it from Dockerfile.ci so it lives in one place. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
ZhiyuLi-Nvidia
force-pushed
the
zhiyul/build-cudnn-fe-megatron-branch
branch
from
October 13, 2026 05:20
9912987 to
23e7a10
Compare
Contributor
Author
|
/ok to test 23e7a10 |
Contributor
|
Automatic Claude reviews have been retired. To request a pull-request review, post a comment containing: Add |
cuichenx
added
the
needs-review
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CUDNN_FRONTEND_GIT_REFbuild arg todocker/Dockerfile.fw_final, pinned to the tip ofNVIDIA/cudnn-frontendbranchfeat/1.29.0-megatron.fw_finalre-syncs withfw_pyproject.toml(pinsnvidia-cudnn-frontend==1.29.0), so an install made earlier inDockerfile.ciwould be replaced.PRESERVE_BASE_RUNTIME=True.pyproject.toml,fw_pyproject.tomloruv.lock. The Bridge CI image (Dockerfile.ci) is unchanged and keeps the locked wheel.Not yet verified
nvidia-cudnn-frontend1.29.0 or higher (gdn_utils.pyexpects at least 1.29.0).Docs and tests
README build-arg table for
Dockerfile.fw_finalupdated. No Python changes, so no unit tests added.🤖 Generated with Claude Code