Repository navigation
Conversation
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable MFSDP v2 MoE checkpoint save/resume in Bridge and verify that resumed training matches uninterrupted training. Bridge currently rejects these checkpoints during config validation. After allowing them, loading into the unwrapped model bypasses the MFSDP adapter's BF16 compute-weight refresh, causing the first resumed loss to differ.
Depends on NVIDIA/Megatron-LM#8230. That fix must be available in Bridge's Core dependency before this PR merges. This PR does not change the Core submodule pin.
Changelog
fsdp_dtensor.GitHub Actions CI
Initial local validation used Core commit
dafb72047b05dac29dacc2be4ecebdafcf3ee21bfrom NVIDIA/Megatron-LM#8230, TE2.18.0+27486e03, and two A6000 GPUs:bb229ffa31bd4566cd3edfff942965de7b789bf2: passed on both ranks using the default test-data fixture, withGH_TOKENsupplied for asset downloads.NotImplementedError.uv run pre-commit run --all-files: passed.--follow-imports=skipreports 235 typing errors across the three changed files; type checking is not clean.Run the new regression with a Core build containing the fix:
Before your PR is "Ready for review"
Additional Information
The test runs automatically through the existing H100 L0 MFSDP launch script. No workflow changes are needed.