Skip to content

Commit 01b38fe

Browse files
authored
Clarify signed commit guidance for mcore-engineers (#7597)
Signed-off-by: Jingyue Wu <jingyuew@nvidia.com>
1 parent 8dded20 commit 01b38fe

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

‎AGENTS.md‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,14 @@ skill keyword — infer it from the artifact you read.
2424

2525
- All PRs must be created as **drafts**. Use `gh pr create --draft` or the GitHub UI draft option.
2626
- Never push branches directly to `https://github.com/NVIDIA/Megatron-LM`. You must push your branch to a personal fork (e.g. `https://github.com/<your-username>/Megatron-LM`), then open a PR from the fork's branch against `NVIDIA/Megatron-LM`.
27-
- When rebasing, cherrypicking or commiting, sign the commits with both `-s` and `-S`: `-s` adds the required
28-
`Signed-off-by` trailer, and `-S` signs the commit so copy-pr-bot and `/ok to
29-
test` can verify the pushed commit without manually specifying the SHA.
30-
Megatron Core engineers at NVIDIA should sign using their NVIDIA emails so they
31-
are automatically added to the right user groups on the internal Slack
32-
workspace.
27+
- When rebasing, cherry-picking or committing, sign the commits with both `-s` and `-S`: `-s` adds the required
28+
`Signed-off-by` trailer, and `-S` signs the commit so copy-pr-bot and
29+
`/ok to test` can verify the pushed commit without manually specifying the SHA.
30+
`/ok to test` is not required for PR authors in `NVIDIA/mcore-engineers` as long as
31+
they sign their commits with `-S`.
32+
- Authors in `NVIDIA/mcore-engineers` should sign using their NVIDIA emails so they
33+
are automatically added to the right user groups on the internal Slack
34+
workspace.
3335
- Before merging any PR, check for open PRs whose GitHub base/diffbase is
3436
`pull-request/<this PR number>`. Retarget every such dependent PR to `main`
3537
before merging; otherwise GitHub may close it and discard review discussion

0 commit comments

Comments
 (0)