Repository navigation
Fix modality MoE padding routing and selective recompute - #7763
Open
HollowMan6 wants to merge 3 commits into
Open
HollowMan6 wants to merge 3 commits into
HollowMan6 wants to merge 3 commits into
Conversation
Preserve dispatcher rows for padded tokens while zeroing their probabilities and excluding them from balance counters. Reuse the regular MoE checkpoint path and avoid unnecessary expert-bias collectives at zero update rate. Signed-off-by: Hollow Man <hollowman@opensuse.org>
HollowMan6
force-pushed
the
modality-moe-padding-bias-fixes
branch
from
September 30, 2026 22:32
b16c8ab to
cecf595
Compare
Contributor
Author
|
@guihong-nv This is a follow-up PR on top of #7502. It fixes padded-token routing by keeping their dispatcher rows while zeroing their probs and leaving them out of the balance counters. It also reuses the regular MoE checkpoint path for selective recompute and skips expert-bias collectives when the update rate is 0. Verified together with NVIDIA-NeMo/Megatron-Bridge#6199. Please let me know if you have any comments. |
svcnvidia-nemo-ci
added
the
waiting-on-maintainers
dimapihtar
added
the
Expert Review
Contributor
|
/ok to test cecf595 |
svcnvidia-nemo-ci
removed
the
waiting-on-maintainers
Signed-off-by: Hollow Man <hollowman@opensuse.org>
svcnvidia-nemo-ci
added
the
waiting-on-maintainers
Signed-off-by: Hollow Man <hollowman@opensuse.org>
This was referenced Oct 11, 2026
Open
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #7502.
Summary
tests/unit_tests/models/test_deepseek_v41_components.py.