Skip to content

ci: Mark flaky dynamic inference functional tests as broken - #8264

Closed
ilml wants to merge 1 commit into
NVIDIA:mainfrom
ilml:ilml/mark-dynamic-inference-flaky
Closed

ilml wants to merge 1 commit into
NVIDIA:mainfrom
ilml:ilml/mark-dynamic-inference-flaky

Conversation

@ilml

@ilml ilml commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

Marks six flaky dynamic inference functional tests as broken by moving each recipe entry to the -broken variant of its existing scopes. The entries are kept, so each test can be re-enabled by dropping the suffix.

Test Platform Scope
gpt_dynamic_inference_tp1_pp1_583m_cuda_graphs_fp8_logitsmatch H100 [mr] → [mr-broken]
gpt_dynamic_inference_tp2_pp2_ep2_gptoss_20b_swa H100, GB200 [mr] → [mr-broken]
gpt_dynamic_inference_tp4_etp1_pp1_ep8_16B_routing_replay_async_sched H100 [mr] → [mr-broken]
gpt_dynamic_inference_tp4_etp1_pp1_ep8_16B_routing_replay_prefix_cache_cudagraph_async_sched H100 [mr] → [mr-broken]
gpt_dynamic_inference_tp4_pp1_ep4_16B_inference_optimized_swiglu_logitsmatch H100 [mr, mr-github-broken] → [mr-broken, mr-github-broken]
gpt_dynamic_inference_tp4_pp1_ep4_16B_inference_optimized_swiglu_logitsmatch GB200 [mr, mr-github] → [mr-broken, mr-github-broken]
hybrid_gdp_dynamic_inference_tp1_pp1_dp8_800m H100 [mr, mr-github] → [mr-broken, mr-github-broken]

Verified with recipe_parser.load_workloads before and after the change (environment=dev, every cadence, H100/GB200/GB300). These six tests drop out of the GitLab mr selection and the GitHub mr-github (L1) selection. No other test is added to or removed from any scope.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • If this PR adds or changes a GPU kernel (Triton, jit_fuser/torch.compile, CUDA extension, TE or external-library dispatch, or a scatter/index accumulation), I have added or updated its bit-exact determinism test and registered it in tests/unit_tests/determinism/kernels/manifest.py (guide)
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

🤖 Generated with Claude Code

@copy-pr-bot

copy-pr-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ilml ilml added the Run tests label Oct 15, 2026
Move the following functional tests to the -broken variant of their
existing scopes so they no longer run in GitLab (mr) or GitHub
(mr-github) CI:

- gpt_dynamic_inference_tp1_pp1_583m_cuda_graphs_fp8_logitsmatch (H100)
- gpt_dynamic_inference_tp2_pp2_ep2_gptoss_20b_swa (H100, GB200)
- gpt_dynamic_inference_tp4_etp1_pp1_ep8_16B_routing_replay_async_sched (H100)
- gpt_dynamic_inference_tp4_etp1_pp1_ep8_16B_routing_replay_prefix_cache_cudagraph_async_sched (H100)
- gpt_dynamic_inference_tp4_pp1_ep4_16B_inference_optimized_swiglu_logitsmatch (H100, GB200)
- hybrid_gdp_dynamic_inference_tp1_pp1_dp8_800m (H100)

The recipe entries are kept so each test can be re-enabled by dropping
the -broken suffix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: ilml <tolong@nvidia.com>
@ilml
ilml marked this pull request as ready for review October 15, 2026 17:45
@ilml
ilml requested a review from a team as a code owner October 15, 2026 17:45
@ilml
ilml requested a review from balasaajay October 15, 2026 17:45
@ilml
ilml requested a review from Phlip79 October 15, 2026 17:48
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Oct 15, 2026
@ilml
ilml enabled auto-merge October 15, 2026 17:54
@ilml

ilml commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 75b618c

This branch is waiting to be deployed

1 active and 1 waiting deployments
test — 75b618c8 Waiting Oct 15, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #24328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low Run tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants