Repository navigation
Conversation
The streaming chat path decoded with `DecodeStream(skip_special_tokens=True)`, which drops every added token flagged `special`. The non-streaming path drops only the tokenizer's special-tokens map (`all_special_tokens`) and trailing EOS ids. Chat tokenizers commonly flag their reasoning and tool-call markers as special without putting them in that map (e.g. `<think>`, `</think>`, `<tool_call>`, `</tool_call>`), so in a stream the reasoning parser never saw `</think>`: the answer and the tool-call markup ended up in `reasoning_content` and no tool call was parsed. Thinking-disabled streams and every non-streaming reply were unaffected. Decode with `skip_special_tokens=False` and drop exactly the ids the non-streaming path drops: `all_special_ids` and the model EOS ids (`model_eos_token_ids`), from both the generated tokens and the prompt prefill. Tokens in the special-tokens map (BOS/EOS/pad) are still dropped. Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
sidsingh-nvidia
approved these changes
Oct 15, 2026
wdykas
approved these changes
Oct 15, 2026
kvareddy
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The streaming chat path decoded with
DecodeStream(skip_special_tokens=True), which drops every added token flaggedspecial. The non-streaming path drops only the tokenizer's special-tokens map (all_special_tokens) and trailing EOS ids. Chat tokenizers commonly flag their reasoning and tool-call markers as special without putting them in that map (e.g.<think>,</think>,<tool_call>,</tool_call>), so in a stream the reasoning parser never saw</think>: the answer and the tool-call markup ended up inreasoning_contentand no tool call was parsed. Thinking-disabled streams and every non-streaming reply were unaffected.Decode with
skip_special_tokens=Falseand drop exactly the ids the non-streaming path drops:all_special_idsand the model EOS ids (model_eos_token_ids), from both the generated tokens and the prompt prefill. Tokens in the special-tokens map (BOS/EOS/pad) are still dropped.Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
jit_fuser/torch.compile, CUDA extension, TE or external-library dispatch, or a scatter/index accumulation), I have added or updated its bit-exact determinism test and registered it intests/unit_tests/determinism/kernels/manifest.py(guide)Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.