Repository navigation
Conversation
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
…-environment Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
|
@ko3n1g Do we care about all failures in merge queue? Originally when this was running on a schedule, it was largely unnecessary because the merge queue guards against unwanted failures. Unlike other repos that do not do merge queues, MLM maybe does not need an alert unless we want one for flaky tests or infra failures, which is a different and larger challenge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Report failures from Megatron-LM's merge-queue testing jobs to the CI Slack channel using the shared notifier from NVIDIA-NeMo/FW-CI-templates#593.
What changed
Add
notify-merge-group-failuretocicd-main.yml, covering the four H100/GB200 unit and integration testing jobs. Alerts run only for uncancelledmerge_groupruns inNVIDIA/Megatron-LMtargeting the repository's default branch, when at least one testing job fails. Scheduled and manually dispatched runs do not send these alerts.Details
flowchart LR A[Merge queue checks requested] --> B[H100 and GB200 unit and integration tests] B --> C{Testing job failed and run uncancelled?} C -->|Yes, canonical default branch| D[Shared failure summary] D --> E[CI Slack channel]Check
github.event.merge_group.base_refagainstrefs/heads/<default_branch>so synthetic queue head refs are accepted. Keep existing workflow triggers and testing jobs unchanged. Pinnotify-ci-failureto631c404d00a9e60afc591cd071d35d2e18f82fc6, useenvironment: mainforSLACK_WEBHOOK, and give the notification job no token permissions or failed-run checkout. Add dependency-free wiring tests to the existing CPU lint job.populate-build-cache.ymlis unchanged.Tested
Validated commit
57f8bf2d22after merging upstreammainatadcd90f4b2:python3 .github/scripts/test_ci_notifications.py: all four tests passed.node /tmp/mlm-pr8289-merge-group/verify-condition.mjs: 4,200 cases passed using@actions/expressions0.3.61, including every testing-job failure, cancellation, alternate targets, fork repositories, synthetic queue refs, schedule, dispatch, push, and pull-request events.main: existing triggers and jobs unchanged after removing the notifier and its lint test step; cache workflow unchanged.actionlint -format '{{json .}}' -stdin-filename .github/workflows/cicd-main.yml -: candidate and upstream have the same 42 diagnostics; no new findings.uvx --from black==26.3.0 black --check .github/scripts/test_ci_notifications.pyanduvx --from isort==5.13.2 isort --check-only .github/scripts/test_ci_notifications.py: passed.BASE_REF=main CHECK_ONLY=true SKIP_DOCS=false bash tools/autoformat.sh: passed; no applicable changes under itsmegatron/coreandtestsscope.git diff --check: passed.mainenvironment currently has no deployment branch restrictions or protection rules, so queue refs can use its secret.Hosted CI and real Slack delivery remain unverified; no test Slack messages were sent.