Skip to content

ci(autobot): enable formal review approvals - #8293

Closed
ko3n1g wants to merge 1 commit into
NVIDIA:mainfrom
ko3n1g:ko3n1g/ci/enable-autobot-review-approval
Closed

ko3n1g wants to merge 1 commit into
NVIDIA:mainfrom
ko3n1g:ko3n1g/ci/enable-autobot-review-approval

Conversation

@ko3n1g

@ko3n1g ko3n1g commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Autobot requires a default-branch policy before it can publish native APPROVE or REQUEST_CHANGES reviews. Without that opt-in, the workflow downgrades those verdicts to COMMENT.

Add .github/autobot/review-config.yml with approval.enabled: true. Permit active members of the existing repository engineering/maintainer and CI automation teams:

  • NVIDIA/mcore-engineers
  • NVIDIA/mcore-reviewers
  • NVIDIA/mcore-leadership
  • NVIDIA/mcore-automation
  • NVIDIA/ci

The policy takes effect after merge to main; the review service checks the requester's active team membership before publishing a formal verdict.

Tested:

  • python3 -c 'from pathlib import Path; import yaml; p = yaml.safe_load(Path(".github/autobot/review-config.yml").read_text()); a = p["approval"]; assert a["enabled"] is True; t = a["eligible_teams"]; assert isinstance(t, list) and t and all(isinstance(x, str) and x and "/" not in x for x in t) and len(t) == len(set(t)); print("approval config valid")' — passed YAML and approval-policy shape checks.
  • git diff --check HEAD^ HEAD — passed.
  • gh api orgs/NVIDIA/teams/<slug> for every configured team — verified each team exists in the repository's organization.
  • BASE_REF=main CHECK_ONLY=true SKIP_DOCS=false bash tools/autoformat.sh — passed; no Python changes.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g marked this pull request as ready for review October 16, 2026 14:53
@ko3n1g
ko3n1g requested a review from a team as a code owner October 16, 2026 14:53
@ko3n1g ko3n1g closed this Oct 16, 2026

This branch was successfully deployed

2 active deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant