Repository navigation
Conversation
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autobot requires a default-branch policy before it can publish native APPROVE or REQUEST_CHANGES reviews. Without that opt-in, the workflow downgrades those verdicts to COMMENT.
Add
.github/autobot/review-config.ymlwithapproval.enabled: true. Permit active members of the existing repository engineering/maintainer and CI automation teams:NVIDIA/mcore-engineersNVIDIA/mcore-reviewersNVIDIA/mcore-leadershipNVIDIA/mcore-automationNVIDIA/ciThe policy takes effect after merge to
main; the review service checks the requester's active team membership before publishing a formal verdict.Tested:
python3 -c 'from pathlib import Path; import yaml; p = yaml.safe_load(Path(".github/autobot/review-config.yml").read_text()); a = p["approval"]; assert a["enabled"] is True; t = a["eligible_teams"]; assert isinstance(t, list) and t and all(isinstance(x, str) and x and "/" not in x for x in t) and len(t) == len(set(t)); print("approval config valid")'— passed YAML and approval-policy shape checks.git diff --check HEAD^ HEAD— passed.gh api orgs/NVIDIA/teams/<slug>for every configured team — verified each team exists in the repository's organization.BASE_REF=main CHECK_ONLY=true SKIP_DOCS=false bash tools/autoformat.sh— passed; no Python changes.