docs(extraction): document audio sentence segments with asr_params (NVBug 6620974) - #2612
Draft
kheiss-uwzoo wants to merge 1 commit into
Draft
docs(extraction): document audio sentence segments with asr_params (NVBug 6620974)#2612kheiss-uwzoo wants to merge 1 commit into
kheiss-uwzoo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_audio_params={"segment_audio": True}, whichGraphIngestor.extract_audio()rejects (AudioChunkParamsextra-forbidden).asr_params=ASRParams(segment_audio=True)on.extract_audio(...), and points to the runnable example on Speech and audio extraction.Test plan
extract_audio()signature andASRParams.segment_audioagainstgraph_ingestor.pyandcommon/params/models.py.audio-video.mdalready usesasr_params=ASRParams(..., segment_audio=True).extract_audio_paramsappears only as a rejected kwarg intest_ingest_interface.py.python -m mkdocs build --strict --config-file mkdocs.ymlfromdocs/(pass after excluding untracked leftover pages that are not in this diff).main.pre-draft: leakage, mkdocs --strict, ::a, ::p, ::r on the diff vs main
Base: upstream/main
Files: docs/docs/extraction/concepts.md
see [CTAs)see [CTAs; nonimOperator/nvcr.io/nim/installFfmpegon concepts.md. Repo leakage script was not present; manualrgused.custom-metadata.mdanduser-defined-stages.md(those fail strict locally and are not in this diff). First local run aborted with 4 leftover-page warnings.extract_audio(asr_params=ASRParams(segment_audio=True))matchesgraph_ingestor.py:645-656,ASRParams.segment_audioinmodels.py:405, andtest_audio_pipeline_batch.py:99-108(95%)refer to, code in backticks, descriptive link, periods)Code drift (not in this docs PR): none for this claim. The bug also recommended a documentation contract test that executes or signature-validates public Python snippets; that is eng/CI work and stays out of this docs PR.
PR: #2612