docs(extraction): document --ray-log-to-driver instead of removed Ray log presets (NVBug 6620618) - #2614
Draft
kheiss-uwzoo wants to merge 2 commits into
Draft
Conversation
… log presets (NVBug 6620618)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INGEST_RAY_LOG_LEVELpresets (PRODUCTION, DEVELOPMENT, DEBUG) that were removed with the legacy nv-ingest framework. Setting the variable is a silent no-op on currentmain.--ray-log-to-driver/--no-ray-log-to-driveronretriever ingest batch, andray_log_to_driveroncreate_ingestor. Keep the nine upstreamRAY_*environment variables.Test plan
INGEST_RAY_LOG_LEVELno longer appears in published docs--ray-log-to-driver/--no-ray-log-to-driveras batch-only, default enabledcreate_ingestor(run_mode=batch, ray_log_to_driver=False)and.ingest()RAY_*rows remain andRAY_LOG_TO_DRIVERis described as not controlling the NRL batchray.init(log_to_driver=...)pathpython -m mkdocs build --strict --config-file mkdocs.ymlfromdocs/pre-draft: leakage, mkdocs --strict, ::a, ::p, ::r on the diff vs main
Base: upstream/main
Files: ray-logging.md
see [CTAs)see [CTAs; nonimOperator/nvcr.io/nim/installFfmpegcustom-metadata.md,user-defined-stages.md) that are not in this diffINGEST_RAY_LOG_LEVELabsent from Python source;ray_log_to_driverdefaultTrue; CLI flag is batch-only;ensure_local_ray_runtimepasseslog_to_drivertoray.init()(95%)RAY_*reference; glob-based.files()exampleCode drift (not in this docs PR): none. The library does not read
INGEST_RAY_LOG_LEVEL. Reimplementing the preset would be a separate eng PR.Overlap: Draft PR #2606 also edits
ray-logging.md(adds one Related Topics link). Resolve that one-line conflict if both land.PR: draft against
main