Skip to content

Replace localstack with ministack - #1296

Open
Nahuel990 wants to merge 1 commit into
NVIDIA:mainfrom
Nahuel990:replace-localstack-with-ministack
Open

Replace localstack with ministack#1296
Nahuel990 wants to merge 1 commit into
NVIDIA:mainfrom
Nahuel990:replace-localstack-with-ministack

Conversation

@Nahuel990

@Nahuel990 Nahuel990 commented Aug 12, 2026

Copy link
Copy Markdown

Swaps the S3 test container image from localstack/localstack:s3-community-archive to ministackorg/ministack:1.4.16, resolving the existing TODO: Switch the localstack image. ministack is an open-source (MIT) AWS emulator that serves the S3 API on the same port (4566) and works under the existing LocalStackContainer fixture with no other changes.

Disclosure: I maintain ministack.

Verified locally by reproducing this file's Testcontainers usage against ministack — the NetworkAwareLocalStackContainer start-override pattern, with_services('s3'), and get_client('s3'), then create_bucket, put_object/get_object, and list_buckets on test-bucket all pass.

Summary by CodeRabbit

  • Tests
    • Updated S3 test environments to use the maintained MiniStack container image.
    • Improved test reliability by replacing the archived LocalStack S3 Community image.

@Nahuel990
Nahuel990 requested a review from a team as a code owner August 12, 2026 21:46
@github-actions github-actions Bot added the external The author is not in @NVIDIA/osmo-dev label Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f8ac1cef-41d3-4579-8b44-3abd88f3e01c

📥 Commits

Reviewing files that changed from the base of the PR and between 8e59c22 and 2077945.

📒 Files selected for processing (1)
  • src/tests/common/storage/s3.py

📝 Walkthrough

Walkthrough

The S3 test fixture now uses the ministackorg/ministack:1.4.16 container image instead of the archived LocalStack S3 Community image.

Changes

S3 test fixture

Layer / File(s) Summary
Update S3 container image
src/tests/common/storage/s3.py
The S3_IMAGE reference now points to ministackorg/ministack:1.4.16.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to 20779

This is a localized test-environment image change, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: adelbertc, aruns-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: replacing LocalStack with Ministack for the S3 test fixture.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external The author is not in @NVIDIA/osmo-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant