Replace localstack with ministack - #1296
Open
Nahuel990 wants to merge 1 commit into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe S3 test fixture now uses the ChangesS3 test fixture
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This is a localized test-environment image change, and no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the S3 test container image from
localstack/localstack:s3-community-archivetoministackorg/ministack:1.4.16, resolving the existingTODO: Switch the localstack image. ministack is an open-source (MIT) AWS emulator that serves the S3 API on the same port (4566) and works under the existingLocalStackContainerfixture with no other changes.Disclosure: I maintain ministack.
Verified locally by reproducing this file's Testcontainers usage against ministack — the
NetworkAwareLocalStackContainerstart-override pattern,with_services('s3'), andget_client('s3'), thencreate_bucket,put_object/get_object, andlist_bucketsontest-bucketall pass.Summary by CodeRabbit