Repository navigation
Commit 3f1f2f2
committed
fix(kubernetes): harden proxy-pod companion lifecycle and placement
Address code review feedback on the proxy-pod topology:
- Clean up companions only on a confirmed CR delete, never on a 409
(replacement) or 404, so a concurrent replacement keeps its Deployment,
Secret, Service, and egress NetworkPolicy.
- On failed companion creation, delete the CR by its returned name with a
UID precondition before removing companions, so shared mode no longer
targets the wrong CR and leaves the workload unfenced.
- Persist the creation-time supervisor topology on each Sandbox CR and
derive status and start/stop/delete behavior from it, so a later gateway
topology change does not reinterpret existing sandboxes.
- Mirror the workload's public platform_config placement (runtime class,
node selector, tolerations) onto the supervisor Deployment so same-node
affinity stays schedulable and runtimes match.
- Grant proxy-pod ClusterRole RBAC in operator mode, not just managed.
- Restrict the OpenShift nonroot-v2 SCC option to shared workspace mode
and document the constraint; fail the Helm render otherwise.
- Correct the debug skill to reference only supervisor ingress port 3128
and note workspace-mode RBAC scoping.
Signed-off-by: Russell Bryant <rbryant@redhat.com>1 parent 59e081b commit 3f1f2f2
6 files changed
Lines changed: 340 additions & 75 deletions
File tree
- .agents/skills/debug-openshell-cluster
- crates/openshell-driver-kubernetes/src
- deploy/helm/openshell
- templates
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
518 | 518 | | |
519 | 519 | | |
520 | 520 | | |
521 | | - | |
522 | | - | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
523 | 526 | | |
524 | 527 | | |
525 | | - | |
526 | | - | |
| 528 | + | |
527 | 529 | | |
528 | 530 | | |
529 | 531 | | |
| |||
0 commit comments