Skip to content

Commit 600d3d3

Browse files
committed
feat(supervisor): advertise accepted application route installations
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
1 parent dfb34da commit 600d3d3

36 files changed

Lines changed: 2640 additions & 468 deletions

File tree

‎.agents/skills/helm-dev-environment/SKILL.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,17 @@ every member one at a time. The PID must survive each case, while an open
195195
replacement confirmed within the recovery timeout, so the runtime terminated
196196
the workload.
197197

198+
For RFC 0017 app-listener validation, enable the listener and supply the app TLS
199+
Secret on the shared Deployment, plus a separate NetworkPolicy allowing the test
200+
client/proxy to reach its app port. Runtime-port access does not grant app access.
201+
Discovery returns the acknowledged owner's Pod IP and app port; no headless app
202+
Service is needed. Exercise HTTP/WebSocket reconnection through graceful downscale
203+
and abrupt loss, preserving workload generation/PID/in-memory state and the public
204+
hostname. Verify stale-owner rejection independently of the replacement's success.
205+
Shared serving leases expire within fifteen seconds of issuance and do not renew
206+
from configuration alone. Do not claim seamless socket migration or infer external
207+
ingress readiness from an advertisement.
208+
198209
### 2. Deploy OpenShell
199210

200211
**Iterative dev** (rebuilds on file changes, recommended during active development):

‎crates/openshell-core/src/app_listener.rs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,12 @@ impl AppListenerConfig {
5050
}
5151
}
5252

53+
/// A synchronous view of installed ingress, evaluated on the sandbox instance
54+
/// runtime. The requested lease must fit entirely within serving freshness.
55+
pub type InstallationSource = std::sync::Arc<
56+
dyn Fn(std::time::Duration) -> crate::proto::SupervisorServiceAdvertisement + Send + Sync,
57+
>;
58+
5359
#[cfg(test)]
5460
mod tests {
5561
use super::*;

‎crates/openshell-driver-docker/src/lib.rs‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3187,6 +3187,18 @@ impl ComputeDriver for ComputeDriverService {
31873187
.await
31883188
}
31893189

3190+
async fn resolve_supervisor_app_endpoint(
3191+
&self,
3192+
_request: Request<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointRequest>,
3193+
) -> Result<
3194+
Response<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointResponse>,
3195+
Status,
3196+
> {
3197+
Err(Status::unimplemented(
3198+
"supervisor application endpoint resolution is not supported",
3199+
))
3200+
}
3201+
31903202
async fn get_sandbox(
31913203
&self,
31923204
request: Request<GetSandboxRequest>,
@@ -3358,6 +3370,18 @@ impl ComputeDriver for DockerComputeDriver {
33583370
Ok(Response::new(ValidateSandboxCreateResponse {}))
33593371
}
33603372

3373+
async fn resolve_supervisor_app_endpoint(
3374+
&self,
3375+
_request: Request<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointRequest>,
3376+
) -> Result<
3377+
Response<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointResponse>,
3378+
Status,
3379+
> {
3380+
Err(Status::unimplemented(
3381+
"supervisor application endpoint resolution is not supported",
3382+
))
3383+
}
3384+
33613385
async fn get_sandbox(
33623386
&self,
33633387
request: Request<GetSandboxRequest>,

‎crates/openshell-driver-kubernetes/src/driver.rs‎

Lines changed: 195 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2227,6 +2227,201 @@ impl KubernetesComputeDriver {
22272227
Ok(())
22282228
}
22292229

2230+
/// Resolve only a unique, live driver-owned supervisor. Multi-member pool
2231+
/// resolution must use the HA assignment/member API rather than guess.
2232+
pub async fn supervisor_app_endpoint(
2233+
&self,
2234+
sandbox_id: &str,
2235+
) -> Result<
2236+
Option<openshell_core::proto::compute::v1::SupervisorAppEndpoint>,
2237+
KubernetesDriverError,
2238+
> {
2239+
if !self.config.sandbox_runtime.app_listener.common.enabled {
2240+
return Ok(None);
2241+
}
2242+
let api = self
2243+
.supported_sandbox_api_for_lookup(self.client.clone())
2244+
.await
2245+
.map_err(KubernetesDriverError::Message)?;
2246+
let objects = api
2247+
.api
2248+
.list(&ListParams::default().labels(&self.sandbox_lookup_selector(sandbox_id)))
2249+
.await
2250+
.map_err(KubernetesDriverError::from_kube)?
2251+
.items;
2252+
let [object]: [DynamicObject; 1] = match objects.try_into() {
2253+
Ok(objects) => objects,
2254+
Err(_) => return Ok(None),
2255+
};
2256+
let namespace = object.metadata.namespace.as_deref().ok_or_else(|| {
2257+
KubernetesDriverError::Precondition("sandbox namespace missing".into())
2258+
})?;
2259+
let uid = object
2260+
.metadata
2261+
.uid
2262+
.as_deref()
2263+
.ok_or_else(|| KubernetesDriverError::Precondition("sandbox UID missing".into()))?;
2264+
let placement = supervisor_placement(&object)?;
2265+
let mut pool_route = String::new();
2266+
let mut ownership_epoch = 0;
2267+
let mut member_address = None;
2268+
let pods = if let SupervisorPlacement::Shared { route } = &placement {
2269+
let Some(shared) = &self.shared_supervisor else {
2270+
return Ok(None);
2271+
};
2272+
let controller = shared.supervision().controller();
2273+
let Some(view) = controller.pool_view() else {
2274+
return Ok(None);
2275+
};
2276+
let Some(owner) = view
2277+
.owners
2278+
.get(route)
2279+
.filter(|_| view.desired.contains(route))
2280+
else {
2281+
return Ok(None);
2282+
};
2283+
let Some(member) = view.members.iter().find(|member| {
2284+
member.member_id == owner.member_id
2285+
&& member.process_id == owner.process_id
2286+
&& !member.leaving
2287+
}) else {
2288+
return Ok(None);
2289+
};
2290+
if !matches!(controller.observed(route),
2291+
openshell_supervisor_control::ObservedInstance::Reported(status)
2292+
if status.sandbox_id == sandbox_id && status.ready
2293+
&& status.phase == openshell_supervisor_control::proto::SandboxInstancePhase::Supervising as i32)
2294+
{
2295+
return Ok(None);
2296+
}
2297+
let address = member
2298+
.runtime_address
2299+
.parse::<std::net::SocketAddr>()
2300+
.map_err(|_| {
2301+
KubernetesDriverError::Precondition(
2302+
"pool member runtime address is not an IP endpoint".into(),
2303+
)
2304+
})?;
2305+
let pod =
2306+
Api::<Pod>::namespaced(self.client.clone(), &shared.config().service_namespace)
2307+
.get_opt(&owner.member_id)
2308+
.await
2309+
.map_err(KubernetesDriverError::from_kube)?;
2310+
let Some(pod) = pod else {
2311+
return Ok(None);
2312+
};
2313+
let service =
2314+
Api::<Service>::namespaced(self.client.clone(), &shared.config().service_namespace)
2315+
.get(&shared.config().service_name)
2316+
.await
2317+
.map_err(KubernetesDriverError::from_kube)?;
2318+
let Some(selector) = service
2319+
.spec
2320+
.as_ref()
2321+
.and_then(|spec| spec.selector.as_ref())
2322+
.filter(|selector| !selector.is_empty())
2323+
else {
2324+
return Ok(None);
2325+
};
2326+
if !selector.iter().all(|(key, value)| {
2327+
pod.metadata
2328+
.labels
2329+
.as_ref()
2330+
.and_then(|labels| labels.get(key))
2331+
== Some(value)
2332+
}) {
2333+
return Ok(None);
2334+
}
2335+
pool_route = route.clone();
2336+
ownership_epoch = owner.auth_epoch;
2337+
member_address = Some(address.ip());
2338+
vec![pod]
2339+
} else {
2340+
let selector =
2341+
format!("openshell.ai/sandbox-id={sandbox_id},openshell.ai/component=supervisor");
2342+
Api::<Pod>::namespaced(self.client.clone(), namespace)
2343+
.list(&ListParams::default().labels(&selector))
2344+
.await
2345+
.map_err(KubernetesDriverError::from_kube)?
2346+
.items
2347+
};
2348+
// Includes terminating members in the ambiguity check; never guess a
2349+
// replacement's ownership during a rollout.
2350+
let [pod]: [Pod; 1] = match pods.try_into() {
2351+
Ok(pods) => pods,
2352+
Err(_) => return Ok(None),
2353+
};
2354+
if pod.metadata.deletion_timestamp.is_some() {
2355+
return Ok(None);
2356+
}
2357+
let app_port = i32::from(self.config.sandbox_runtime.app_listener.common.port);
2358+
if !pod
2359+
.spec
2360+
.as_ref()
2361+
.and_then(|spec| {
2362+
spec.containers
2363+
.iter()
2364+
.find(|container| container.name == "supervisor")
2365+
})
2366+
.is_some_and(|container| {
2367+
container.ports.as_ref().is_some_and(|ports| {
2368+
ports.iter().any(|port| {
2369+
port.name.as_deref() == Some("app") && port.container_port == app_port
2370+
})
2371+
}) && container.env.as_ref().is_some_and(|env| {
2372+
env.iter().any(|entry| {
2373+
entry.name == "OPENSHELL_APP_LISTENER_ENABLED"
2374+
&& entry.value.as_deref() == Some("true")
2375+
})
2376+
})
2377+
})
2378+
{
2379+
return Ok(None);
2380+
}
2381+
let Some(pod_uid) = pod.metadata.uid.as_deref() else {
2382+
return Ok(None);
2383+
};
2384+
if matches!(placement, SupervisorPlacement::Dedicated)
2385+
&& !pod
2386+
.metadata
2387+
.owner_references
2388+
.as_ref()
2389+
.is_some_and(|owners| owners.iter().any(|o| o.uid == uid && o.kind == "Sandbox"))
2390+
{
2391+
return Ok(None);
2392+
}
2393+
let Some(status) = pod.status else {
2394+
return Ok(None);
2395+
};
2396+
if status.phase.as_deref() != Some("Running") {
2397+
return Ok(None);
2398+
}
2399+
let Some(host) = status
2400+
.pod_ip
2401+
.filter(|ip| ip.parse::<std::net::IpAddr>().is_ok())
2402+
else {
2403+
return Ok(None);
2404+
};
2405+
if member_address
2406+
.is_some_and(|address| host.parse::<std::net::IpAddr>().ok() != Some(address))
2407+
{
2408+
return Ok(None);
2409+
}
2410+
let component = match placement {
2411+
SupervisorPlacement::Dedicated => pod_uid.to_string(),
2412+
SupervisorPlacement::Shared { route } => route,
2413+
};
2414+
Ok(Some(
2415+
openshell_core::proto::compute::v1::SupervisorAppEndpoint {
2416+
host,
2417+
port: u32::from(self.config.sandbox_runtime.app_listener.common.port),
2418+
runtime_identity: kubernetes_runtime_identity(namespace, uid, &component),
2419+
pool_route,
2420+
ownership_epoch,
2421+
},
2422+
))
2423+
}
2424+
22302425
pub async fn get_sandbox(&self, sandbox_id: &str) -> Result<Option<Sandbox>, String> {
22312426
info!(
22322427
sandbox_id = %sandbox_id,

‎crates/openshell-driver-kubernetes/src/grpc.rs‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,37 @@ impl ComputeDriver for ComputeDriverService {
107107
.await
108108
}
109109

110+
async fn resolve_supervisor_app_endpoint(
111+
&self,
112+
request: Request<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointRequest>,
113+
) -> Result<
114+
Response<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointResponse>,
115+
Status,
116+
> {
117+
self.rpc_tracer
118+
.trace(
119+
openshell_otel::rpc::RESOLVE_SUPERVISOR_APP_ENDPOINT,
120+
async {
121+
let request = request.into_inner();
122+
if request.sandbox_id.is_empty() {
123+
return Err(Status::invalid_argument("sandbox_id is required"));
124+
}
125+
let endpoint = self
126+
.driver
127+
.supervisor_app_endpoint(&request.sandbox_id)
128+
.await
129+
.map_err(|e| Status::unavailable(e.to_string()))?;
130+
Ok(Response::new(
131+
openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointResponse {
132+
sandbox_id: request.sandbox_id,
133+
supervisor_app_endpoint: endpoint,
134+
},
135+
))
136+
},
137+
)
138+
.await
139+
}
140+
110141
async fn get_sandbox(
111142
&self,
112143
request: Request<GetSandboxRequest>,

‎crates/openshell-driver-mxc/src/grpc.rs‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,18 @@ impl ComputeDriver for ComputeDriverService {
7070
Ok(Response::new(ValidateSandboxCreateResponse {}))
7171
}
7272

73+
async fn resolve_supervisor_app_endpoint(
74+
&self,
75+
_request: Request<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointRequest>,
76+
) -> Result<
77+
Response<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointResponse>,
78+
Status,
79+
> {
80+
Err(Status::unimplemented(
81+
"supervisor application endpoint resolution is not supported",
82+
))
83+
}
84+
7385
async fn get_sandbox(
7486
&self,
7587
request: Request<GetSandboxRequest>,

‎crates/openshell-driver-podman/src/grpc.rs‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,18 @@ impl ComputeDriver for ComputeDriverService {
102102
.await
103103
}
104104

105+
async fn resolve_supervisor_app_endpoint(
106+
&self,
107+
_request: Request<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointRequest>,
108+
) -> Result<
109+
Response<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointResponse>,
110+
Status,
111+
> {
112+
Err(Status::unimplemented(
113+
"supervisor application endpoint resolution is not supported",
114+
))
115+
}
116+
105117
async fn get_sandbox(
106118
&self,
107119
request: Request<GetSandboxRequest>,

‎crates/openshell-driver-vm/src/driver.rs‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5362,6 +5362,18 @@ impl ComputeDriver for VmDriver {
53625362
Ok(Response::new(response))
53635363
}
53645364

5365+
async fn resolve_supervisor_app_endpoint(
5366+
&self,
5367+
_request: Request<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointRequest>,
5368+
) -> Result<
5369+
Response<openshell_core::proto::compute::v1::ResolveSupervisorAppEndpointResponse>,
5370+
Status,
5371+
> {
5372+
Err(Status::unimplemented(
5373+
"supervisor application endpoint resolution is not supported",
5374+
))
5375+
}
5376+
53655377
async fn get_sandbox(
53665378
&self,
53675379
request: Request<GetSandboxRequest>,

‎crates/openshell-otel/src/grpc.rs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,10 @@ pub mod rpc {
106106
"GetSandbox",
107107
"openshell.compute.v1.ComputeDriver/GetSandbox",
108108
);
109+
pub const RESOLVE_SUPERVISOR_APP_ENDPOINT: ComputeDriverRpc = ComputeDriverRpc::new(
110+
"ResolveSupervisorAppEndpoint",
111+
"openshell.compute.v1.ComputeDriver/ResolveSupervisorAppEndpoint",
112+
);
109113
pub const LIST_SANDBOXES: ComputeDriverRpc = ComputeDriverRpc::new(
110114
"ListSandboxes",
111115
"openshell.compute.v1.ComputeDriver/ListSandboxes",
@@ -195,6 +199,7 @@ pub fn compute_driver_rpc_operation(path: &str) -> Option<ComputeDriverRpc> {
195199
Some("ValidateSandboxCreate") => Some(rpc::VALIDATE_SANDBOX_CREATE),
196200
Some("CreateSandbox") => Some(rpc::CREATE_SANDBOX),
197201
Some("GetSandbox") => Some(rpc::GET_SANDBOX),
202+
Some("ResolveSupervisorAppEndpoint") => Some(rpc::RESOLVE_SUPERVISOR_APP_ENDPOINT),
198203
Some("ListSandboxes") => Some(rpc::LIST_SANDBOXES),
199204
Some("StopSandbox") => Some(rpc::STOP_SANDBOX),
200205
Some("StartSandbox") => Some(rpc::START_SANDBOX),
@@ -318,6 +323,7 @@ mod tests {
318323
rpc::VALIDATE_SANDBOX_CREATE,
319324
rpc::CREATE_SANDBOX,
320325
rpc::GET_SANDBOX,
326+
rpc::RESOLVE_SUPERVISOR_APP_ENDPOINT,
321327
rpc::LIST_SANDBOXES,
322328
rpc::STOP_SANDBOX,
323329
rpc::START_SANDBOX,

0 commit comments

Comments
 (0)