Skip to content

Commit 60598bc

Browse files
committed
test(oidc): align provider fixtures with profiles
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
1 parent 091c08c commit 60598bc

3 files changed

Lines changed: 13 additions & 9 deletions

File tree

e2e/python/oidc/oidc_auth_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def test_admin_can_create_provider(self) -> None:
5454
provider=datamodel_pb2.Provider(
5555
metadata=datamodel_pb2.ObjectMeta(name="e2e-oidc-admin-test"),
5656
type="claude",
57-
credentials={"API_KEY": "test-value"},
57+
credentials={"ANTHROPIC_API_KEY": "test-value"},
5858
)
5959
)
6060
try:
@@ -78,7 +78,7 @@ def test_user_cannot_create_provider(self) -> None:
7878
provider=datamodel_pb2.Provider(
7979
metadata=datamodel_pb2.ObjectMeta(name="e2e-oidc-user-blocked"),
8080
type="claude",
81-
credentials={"API_KEY": "test-value"},
81+
credentials={"ANTHROPIC_API_KEY": "test-value"},
8282
)
8383
)
8484
with pytest.raises(grpc.RpcError) as exc_info:

e2e/python/oidc/workspace_authz_test.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def _workspace_rpcs() -> list[tuple[str, Callable]]:
248248
name="authz-test", workspace=WS
249249
),
250250
type="claude",
251-
credentials={"K": "v"},
251+
credentials={"ANTHROPIC_API_KEY": "v"},
252252
),
253253
),
254254
metadata=m,
@@ -277,7 +277,7 @@ def _workspace_rpcs() -> list[tuple[str, Callable]]:
277277
name="nonexistent", workspace=WS
278278
),
279279
type="claude",
280-
credentials={"K": "v"},
280+
credentials={"ANTHROPIC_API_KEY": "v"},
281281
),
282282
),
283283
metadata=m,
@@ -666,7 +666,7 @@ def seed_provider(self, admin_ctx: Any, workspace: str) -> Any:
666666
name=prov_name, workspace=workspace
667667
),
668668
type="claude",
669-
credentials={"API_KEY": "test"},
669+
credentials={"ANTHROPIC_API_KEY": "test"},
670670
),
671671
),
672672
metadata=metadata,
@@ -977,7 +977,7 @@ def test_user_member_admin_operations_denied(
977977
name="user-blocked", workspace=WS
978978
),
979979
type="claude",
980-
credentials={"K": "v"},
980+
credentials={"ANTHROPIC_API_KEY": "v"},
981981
),
982982
),
983983
metadata=user_md,
@@ -1046,7 +1046,7 @@ def test_workspace_admin_can_create_provider(
10461046
provider=datamodel_pb2.Provider(
10471047
metadata=datamodel_pb2.ObjectMeta(name=prov_name, workspace=WS),
10481048
type="claude",
1049-
credentials={"K": "v"},
1049+
credentials={"ANTHROPIC_API_KEY": "v"},
10501050
),
10511051
),
10521052
metadata=user_md,

e2e/rust/tests/oidc_pkce.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1555,11 +1555,15 @@ fn assert_platform_admin_denial(output: &Output, action: &str) {
15551555

15561556
fn assert_non_member_denial(output: &Output, action: &str) {
15571557
let denied = combined_output(output);
1558+
let compact_denial: String = denied
1559+
.chars()
1560+
.filter(|character| !character.is_whitespace() && *character != '│')
1561+
.collect();
15581562
assert!(
15591563
!output.status.success()
1560-
&& denied
1564+
&& compact_denial
15611565
.to_ascii_lowercase()
1562-
.contains("not a member of workspace"),
1566+
.contains("notamemberofworkspace"),
15631567
"non-member unexpectedly authorized to {action}, or denial omitted membership context:\n{denied}"
15641568
);
15651569
}

0 commit comments

Comments
 (0)