Skip to content

Commit e87f19d

Browse files
purpclaude
andcommitted
fix(codeowners): name the outside collaborators on the enforcement paths
@mrunalp, @sjenning, and @derekwaynecarr are maintainers but not members of @NVIDIA/openshell-codeowners, and as outside collaborators they cannot join it. Owning these paths by team alone would have meant no Red Hat maintainer could approve a change to the merge gate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
1 parent a56320b commit e87f19d

1 file changed

Lines changed: 13 additions & 9 deletions

File tree

‎.github/CODEOWNERS‎

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
# Vouch list — maintainers only (bot commits bypass, but manual edits need review)
55
.github/VOUCHED.td @NVIDIA/openshell-codeowners
66

7-
# Merge enforcement — these paths decide who can merge. They keep an explicit
8-
# owner so the rules below survive the wildcard above being scoped down.
7+
# Merge enforcement — these paths decide who can merge, so they keep an explicit
8+
# owner independent of any broad ownership rule above.
99
#
1010
# A workflow triggered by pull_request_review runs the pull request's copy of
1111
# the workflow file, not the one on main, so a contributor can rewrite the
@@ -16,10 +16,14 @@
1616
#
1717
# The whole workflows directory is covered, not just the approval gate, because
1818
# any workflow can claim a required check context or ask for a broader token.
19-
/.github/workflows/ @NVIDIA/openshell-codeowners
20-
/.github/actions/ @NVIDIA/openshell-codeowners
21-
/.github/CODEOWNERS @NVIDIA/openshell-codeowners
22-
/.github/zizmor.yml @NVIDIA/openshell-codeowners
23-
/MAINTAINERS.md @NVIDIA/openshell-codeowners
24-
/tasks/scripts/check_maintainer_approval.py @NVIDIA/openshell-codeowners
25-
/tasks/scripts/alert_maintainer_change.py @NVIDIA/openshell-codeowners
19+
#
20+
# The three logins are named alongside the team because they are outside
21+
# collaborators and cannot join it. Owning these paths by team alone would mean
22+
# no Red Hat maintainer could approve a change to the merge gate.
23+
/.github/workflows/ @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarr
24+
/.github/actions/ @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarr
25+
/.github/CODEOWNERS @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarr
26+
/.github/zizmor.yml @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarr
27+
/MAINTAINERS.md @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarr
28+
/tasks/scripts/check_maintainer_approval.py @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarr
29+
/tasks/scripts/alert_maintainer_change.py @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarr

0 commit comments

Comments
 (0)