You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit f01a664
Browse filesBrowse the repository at this point in the historyBrowse files
docs: clarify vouch timing, DCO vs signing, and PR checklist guidance (#2810)
Spell out that auto-closed PRs keep their discussion and can be reopened or replaced, separate DCO sign-off from cryptographic commit signing, and say to mark PR checklist items complete only after verification.
Signed-off-by: politerealism <burdcat17@gmail.com>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+11-4Lines changed: 11 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -27,9 +27,9 @@ We use a vouch system. This exists because AI makes it trivial to generate plaus
27
27
3. Write in your own words. AI-generated vouch requests will be denied.
28
28
4. A maintainer will comment `/vouch` if approved, and the request discussion
29
29
will close automatically.
30
-
5. Once vouched, you can submit pull requests.
30
+
5.**Get vouched before opening a PR.**Once vouched, you can submit pull requests.
31
31
32
-
**If you are not vouched, any pull request you open will be automatically closed.** Org members and collaborators with push access bypass this check.
32
+
**If you are not vouched, any pull request you open will be automatically closed.**The PR and its discussion are preserved. Once vouched, open a new PR (preferred) or reopen the closed one. It cannot be held open or converted to a draft to bypass the check. Org members and collaborators with push access bypass this check.
33
33
34
34
### Finding Work
35
35
@@ -490,10 +490,17 @@ By making a contribution to this project, I certify that:
490
490
```
491
491
492
492
```bash
493
-
git commit -s -m"feat(sandbox): add new capability"
493
+
git commit --signoff --message"feat(sandbox): add new capability"
494
494
```
495
495
496
-
DCO sign-off is separate from cryptographic commit signing. CI requires signing for org members so that copy-pr-bot can mirror your PR automatically; see [CI.md](CI.md#commit-signing) for setup.
496
+
DCO sign-off is separate from cryptographic commit signing, and the two have different requirements:
497
+
498
+
-**DCO sign-off** (`--signoff`) adds the `Signed-off-by` trailer to each commit. It applies to every contributor. The DCO Assistant bot also asks you to sign the DCO once, by commenting on your PR.
499
+
-**Cryptographic commit signing** applies to org members and collaborators only. CI requires it so that copy-pr-bot can mirror your PR automatically; see [CI.md](CI.md#commit-signing) for setup.
500
+
501
+
### PR testing checklist
502
+
503
+
Only mark a checklist item as complete after you have run and verified it, not as a plan for what you intend to test. Unchecked boxes at submission are fine; they show what still needs verification before merge.
0 commit comments