feat(docker): prototype attach-driven isolation boundaries - #2965
Draft
drew wants to merge 8 commits into
Draft
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-2965.docs.buildwithfern.com/openshell |
9 tasks
Signed-off-by: Drew Newberry <385+drew@users.noreply.github.com>
Signed-off-by: Drew Newberry <385+drew@users.noreply.github.com>
Signed-off-by: Drew Newberry <385+drew@users.noreply.github.com>
Signed-off-by: Drew Newberry <385+drew@users.noreply.github.com>
Signed-off-by: Drew Newberry <385+drew@users.noreply.github.com>
Signed-off-by: Drew Newberry <385+drew@users.noreply.github.com>
drew
force-pushed
the
codex/docker-host-supervisor
branch
from
September 1, 2026 00:13
3f387e4 to
9f08093
Compare
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
This was referenced Sep 1, 2026
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the Docker proof for RFC 0012's attach-driven isolation boundary. This is PR 4 of 4 in the review stack and is stacked on the host-supervised VM prototype in #2945.
The proof runs the logical supervisor on the host and launches the admitted agent image directly, without an OpenShell supervisor binary inside the workload container. The compute driver passes trusted prepared inputs in a
TopologyDescriptor;IsolationBackend::attachcreates or locates the stopped container and atomically binds it to the sandbox context. There is no separate backendcreateordestroyoperation. The compute driver retains durable deletion and reconciliation ownership.Stack: #2941 → #2942 → #2945 → this PR.
Related Issue
Part of #1737. Builds on RFC #2048 and the RFC 0012 implementation stack.
Changes
IsolationBackendattach-only and remove the parallel create/provision/destroy contract types and registry path.TopologyDescriptorpayloads to carry existing-resource coordinates or trusted prepared inputs used duringattach.DockerIsolationBackendwhoseattachimplementation creates or locates the stopped container, disables direct networking, drops all capabilities, and binds the resource before returningBound.SCM_RIGHTS, validate listener metadata and container identity, and keep the listener active for later Docker exec processes.--topology-*supervisor flags.Testing
mise run pre-commitcargo check -p openshell-isolation -p openshell-driver-docker -p openshell-sandbox --all-targetscargo test -p openshell-isolation(21 passed)cargo test -p openshell-driver-docker --lib(71 passed, 1 daemon test ignored)cargo test -p openshell-sandbox --lib(102 passed)mise run e2e:dockeron an ARM64 Docker daemon, including sandbox create, supervisor registration, and sandbox execChecklist