Repository navigation
[None][feat] Add VisualGen P0/P1 usage telemetry - #19734
Draft
Mgluhovskoi wants to merge 8 commits into
Draft
Mgluhovskoi wants to merge 8 commits into
Mgluhovskoi wants to merge 8 commits into
Conversation
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Mgluhovskoi
force-pushed
the
feat/visualgen-telemetry-main
branch
from
October 2, 2026 00:35
7f5f021 to
db3055a
Compare
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
…isclosure Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add VisualGen usage telemetry with the P0 field inventory and most P1 fields, reusing TRT-LLM's reporter, opt-outs, lifecycle tracking, and terminal delivery.
This PR targets
NVIDIA/TensorRT-LLM:feat/visualgen-telemetryand replaces the fork-only draft Mgluhovskoi/TensorRT-LLM#1. It builds on the initial work in #18679. The target branch was fast-forwarded to main at7d391a06d7fbcc1e577072b5260568597e15c237on October 25, 2026, and this PR merges that same revision. Its diff against the target remains scoped to VisualGen telemetry.Retain draft status for code review and end-to-end validation. Schema and dashboard rollout dependencies remain separate from this change of PR target.
Field coverage
tensorrt_llm/usage/schemas/README.mddocuments exact wire names, buckets, aggregation semantics, and limitations.Privacy and compatibility
VisualGenArgsdump. No VisualGen architecture hash is added.other; enums and histogram keys are fixed. Do not send prompts, reference media, generated outputs, paths, arbitrary extra-parameter keys/values, exception text, or request identifiers.Explicit limits
failedComponentisnoneorunclassified; component-level loader failure attribution remains incomplete.extraParamsKeysUsedcurrently allows only the explicitly reviewedstg_scalename. Additional names require review.October 25 compatibility updates
tp_layoutorsmooth_vtelemetry fields in this update.Validation and rollout
1.4.0rc0.dev202610050000container with networking disabled, mounted test dependencies, and temporary package bootstraps. No environment workaround is committed.kv_cache_manager_v2.DEFAULT_COLD_TIER_OFFLOAD_MIN_PRIORITY, which that container does not provide. Full CLI, VisualGen lifecycle, and end-to-end tests still need a matching build/CI environment.git diff --checkpass. Telemetry-reference regeneration is idempotent. Regenerated the golden manifest; its only difference from the updated target is thevisual_gen_classusage-context value.